If a room doesn't exist hipchat will break a node submit because of exception

HipChat\HipChat_Exception: HipChat API error: code=404, info=HTTP status code: 404, response={"error":{"code":404,"type":"Not Found","message":"Room not found: faceroom"}}

this should be caught so it doesn't break drupal

CommentFileSizeAuthor
#1 2334585-hipchat-exceptions.patch672 bytescoltrane
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

coltrane’s picture

Status: Active » Needs review
FileSize
672 bytes

Patch not yet tested, I didn't setup a local test or try against our prod site.

  • greggles committed f055a17 on 7.x-1.x authored by coltrane
    Issue #2334585 by coltrane: Catch exceptions in sending messages to...
greggles’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Thanks, Ben! I've applied this to 7.x-1.x.

I don't maintain 6.x-1.x, but if someone who cares about that posts a patch I can commit it.

  • greggles committed f055a17 on 7.x-2.x authored by coltrane
    Issue #2334585 by coltrane: Catch exceptions in sending messages to...

  • greggles committed f055a17 on 8.x-1.x authored by coltrane
    Issue #2334585 by coltrane: Catch exceptions in sending messages to...
greggles’s picture

Status: Patch (to be ported) » Fixed

I guess no need to port to 6.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.