Undefined Function: Dependency on Field Analytics Module

confirming

in highcharts_views.options.inc begin on line 134

two option

we add the dependency or the function get refactored.

Same error. I added a patch that contains the function from field_analytics module.

Great work guys!

Quick patch review:

+++ b/views/highcharts_views.options.incundefined
@@ -154,6 +154,42 @@ abstract class ViewsHighchartsOptions extends HighchartsOptions {
+  function field_get_allowed_values($instance) {

I agree highcharts_views.module shouldn't depend on field_analytics.module.

We may or may not need a new method (see below). But if we do, let's be sure to camel case - like getAllowedValues.

+++ b/views/highcharts_views.options.incundefined
@@ -154,6 +154,42 @@ abstract class ViewsHighchartsOptions extends HighchartsOptions {
+    switch ($field['type']) {

I know this is from my original function from field_analytics.module, but since then I've realized we can take advantage of hook_options_list(), one way or another.

In D7 we may even be able to use the sudo-private function _options_get_options(), though I haven't tried it yet - does someone want to give that a shot?

Looking at that function, if it conflicts with our empty_option, we may want our own method after all, borrowing most of _options_get_options(), but without the empty_option assumption (since we're adding the options into our own field with it's own empty_options).

Note that D8 is somewhat of a moving target on this - noting that _options_get_options() has been removed. There is a D8 patch that will solve this very issue #1758622: Provide the options list of an entity field, but it still in progress. Additionally noting changes to hook_options_list() are in progress: #1950632: Create a FieldDefinitionInterface and use it for formatters and widgets so we should keep an eye out for that as well.

thanks!