Since webform uses the webform-submit class, it seems that hide_submit does not attach itself to Webform elements properly. The JS can be modified to include those classes as well.

CommentFileSizeAuthor
#2 2751191-webform.patch3.56 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

vilepickle created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review
FileSize
2751191-webform.patch3.56 KB
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

It doesn't seem great to add classes that are specific to another module. I wonder if there's another way to go after this problem.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Yeah, we've had conflicts with hide_submit being too heavy handed with the better_exposed_filters submit button for auto submit (from ctools) as well. The module seems pretty heavy handed in general and I wish it was a bit more granular on what inputs it replaces as buttons. Also it replaces things in our admin theme which styles the buttons differently.

sumthief’s picture

sumthief CreditAttribution: sumthief as a volunteer and at DrupalJedi commented
Status: Needs review » Active

@vilepickle
Looks strange.

Because I've checked webform (7.x-4.14) + hide_submit (both 7.x-2.4 and 7.x-2.x-dev versions) interaction on clean Drupal installation (7.50) and it works perfect (for all blocking methods).

You can check inlcudes/form.inc for function theme_button:

$element['#attributes']['class'][] = 'form-' . $element['#button_type'];

Please check that your project`s codebase have no overrides of theme_button.

david.hughes’s picture

david.hughes
he/him
Primary language English
CreditAttribution: david.hughes at Cancer Research UK commented

Shooting in the dark on an older issue but...

#3 Could the selectors not be based on a setting within the module, allowing developers to specify the class names of the buttons?

I'm dealing with this issue affecting my client and considering running this module but with a patch to this effect.