As the title says. It was disabling/hiding one of the buttons but not the very last submit button at the bottom (ie. the primary submit button). So I made a change to the js file that comes with the module:

if (settings.hide_submit_hide_fx)
{
  //$('input.form-submit', $form).addClass(settings.hide_submit_css).fadeOut(100).eq(0).after(pdiv);
  //$('input.form-submit', $form).next().fadeIn(100);
  $('#edit-actions input.form-submit', $form).addClass(settings.hide_submit_css).fadeOut(100).eq(0).after(pdiv);
  $('#edit-actions input.form-submit', $form).next().fadeIn(100);
}
else
{
  //$('input.form-submit', $form).addClass(settings.hide_submit_css).hide().eq(0).after(pdiv);
  $('#edit-actions input.form-submit', $form).addClass(settings.hide_submit_css).hide().eq(0).after(pdiv);
}
CommentFileSizeAuthor
#5 hide_submit-multiple_submit_disable-2035631-5.patch1.99 KBsumthief
#3 hide_submit-submit-button-not-2035631-3.patch1.82 KBNWOM
#1 2035631_hide_all_buttons_in_form.patch1.18 KBgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Active » Needs review
FileSize
2035631_hide_all_buttons_in_form.patch1.18 KB

Here's a patch version of your changes.

PhilY’s picture

PhilY
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
CreditAttribution: PhilY commented
Issue summary: View changes

Works fine, thank you

NWOM’s picture

NWOM CreditAttribution: NWOM commented
FileSize
hide_submit-submit-button-not-2035631-3.patch1.82 KB

Here is a re-roll for the newest dev with a small typo fix

sumthief’s picture

sumthief CreditAttribution: sumthief as a volunteer and at DrupalJedi commented
Status: Needs review » Needs work

This patch looks not good.

Because identifier which you want to use as a base (parent) element for searching in is not reliable.
I mean that if you'll check includes/form.inc and find function "form_builder" and check this code then you will see what I am talking about:

  if (!isset($element['#id'])) {
    $element['#id'] = drupal_html_id('edit-' . implode('-', $element['#parents']));
  }

Identifier #edit-actions will be generated for the form element which contained in 'actions' key. But if somebody will define element with type 'actions' but put it into the 'buttons' (for example) key we will get '#edit-buttons' identifier.

So this patch is not suitable for us.

sumthief’s picture

sumthief CreditAttribution: sumthief as a volunteer and at DrupalJedi commented
FileSize
hide_submit-multiple_submit_disable-2035631-5.patch1.99 KB

Tried to make a patch with no dependency on element id.
It appends progress indicator to each button. But I don't sure that this is the source issue.

P.S.: Pastebin for reproduce problem - http://pastebin.com/dmh0NbBQ.

sumthief’s picture

sumthief CreditAttribution: sumthief as a volunteer and at DrupalJedi commented
Status: Needs work » Needs review
sumthief’s picture

sumthief CreditAttribution: sumthief as a volunteer and at DrupalJedi commented
Status: Needs review » Postponed (maintainer needs more info)

@hga77

Please could you provide more information how to reproduce the problem (for example you can give us form example from core or contrib, or code snippets)?