heartbeat.js refresh in heartbeat.entity.inc [#1363260]

In the file heartbeat.entity.inc at the line 242 the /js is missing in front of heartbeat.js so the stream are not refreshing.

Old line: drupal_get_path('module', 'heartbeat') . '/heartbeat.js',
New line: drupal_get_path('module', 'heartbeat') . '/js/heartbeat.js',

After that the stream refresh correctly.

Comments

Comment #1

Stalski CreditAttribution: Stalski commented 7 December 2011 at 15:19

Status:

Needs review

» Fixed

Wow, that was sloppy of me :( . Thanks for the fix. This has been pushed to git.

I am also very very happy to see that people already are using this very newly created feature. I will take this moment to ask you what you think of that concept. So the approach is to expose a heartbeat template (which is a normal entity bundle) to the stream by prepending it.

What I have locally set up is a facebook alike share thing, set-up like this:
- A heartbeat message template "heartbeat_share"
- One of the streams, public activity is configured to have the message template "heartbeat_share" as stream attachment.
- The message template has a couple of new display fields (an image, a video, ...)
- The Fieldgroup (sorry also mine) then groups those media fields in a wrapper (E.g. I used collapsible divs) to toggle the kind of share.

How are you currently using this feature? The fact that you came accross this bug is really thumbs up ;)

Comment #2

sw3b CreditAttribution: sw3b commented 7 December 2011 at 16:28

Let me juste add that we are planning a community website on the world of cars and all the new feature you just write down, well, i'm looking for this ! If you are ready to push a DEV with the sharing like facebook, go ahead, i'm ready to test it with my setup. I think the concept is great.

Fo the JS refresh feature, yes i'm using it. I set it up to 60 secondes. I will probably set it to 10 or 30 sec but it will depend on the server load. I think to shorter the time the harder it will be for the server. I came with this bug after reviewing the report log of Drupal. The were an error in the logs.

When I'm ready I will send you an invite for my website to have a look of what we did with heartbeat. We also have install user relationship, private message, shoutbox, forum, image gallery, video, article (using it for blog) and of course heartbeat ! A lot more to come also and heartbeat will become the center piece of all the website, a bit like facebook.

So all the new concept/feature you are planning we be appreciated and configure on our site. ;o)

If you need a tester, i'm there !!!!

Comment #3

Stalski CreditAttribution: Stalski commented 8 December 2011 at 20:58

A few remarks:
- The shorter the polling, the harder on the server, that's a fact. In fact, it can get your server down. That's why I wrote heartbeat_nodejs. This way you can have auto! pushing from a nodejs server. The only problem is that it still needs work due to permissions.
- The feature with share as FB is not something to commit. You can create that already with little css/js tweaks.

Comment #4

sw3b CreditAttribution: sw3b commented 15 December 2011 at 18:05

Do you have a recipe to have an image field show in the activity stream ?!? Like when user add a new image it show a thumbnail in the activity stream. is it possible to do it ?!?

Comment #5

Stalski CreditAttribution: Stalski commented 15 December 2011 at 22:17

Ofcourse . Thats the idea.
If you mean a heartbear template entity form above the stream. Then its just the manage display screen.
Other images inside the template itself is handled by tokens in the rules action

If you trigger heartbeat sctivity logging custom, then you create variable custom