1. When tokens to create links on entities (nodes, user, taxonomies, ...) are provided by the tokens module, heartbeat will remove the tokens from heartbeat itself. That would require configuration altering in the rules you are using.

2. Move the token implementation to separate .tokens.inc files.

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Side note, the tokens themselves shouldn't change names, so I'm not sure they should require altering the rules?

Stalski’s picture

Stalski CreditAttribution: Stalski commented

Well that's what I meant. If node:link is provided by tokens, nothing is needed. if it'll be entity:link only, then I might be able to give backward compatibility for the node:link but it's hard to change node:link into entity:link in rules data if I recollect well.
So providing the node:link and user:link would be super.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I didn't make myself clear, the actual tokens will be [node:link], [comment:link], [user:link] where the first part is any entity type that supports an uri callback, and not actually [entity:link].

Stalski’s picture

Stalski CreditAttribution: Stalski commented

yes I know, it does not matter that much, as long as I know when heartbeat does not have to support them anymore. Any progress on this yet?

Stalski’s picture

Stalski CreditAttribution: Stalski commented
Status: Active » Postponed