I'm not sure if this is a bug on the module's part but there is a work around. The issue is that the Javascript being added via the hook_page_attachments_alter is being truncated/escaped. I've managed to fix this myself by adding code of the form

use Drupal\Core\Render\Markup;

...


$attachments['#attached']['html_head'][$i] = [
     [
       '#type'  => 'html_tag',
       '#tag'   => $script_tag,
       '#value' => Markup::create($value),
     ],
        'header-and-footer-scripts-' . $i,
    ];

And that appears to allow the script to pass through and function. There appears to be a support request in the Issue queue for D8 core that I believe is related to this problem.

CommentFileSizeAuthor
#11 header_and_footer_scripts-javascript-comments-fix-3050967-11.patch2.57 KBNitesh Sethia
#10 header_and_footer_scripts_value_markup.patch2.21 KBJesmaster
#6 header_and_footer_scripts-javascript-comments-fix-3050967-4.patch1.06 KBdhanlal
#3 header_and_footer_scripts-javascript-comments-fix-3050967-3.patch1.06 KBakbuje
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edward.radau created an issue. See original summary.

akbuje’s picture

akbuje CreditAttribution: akbuje as a volunteer commented
Related issues: +#3013662: Comments don't work, +#3047986: Javascript Comments Break Javascript

I found your fix useful in my usecase @edvard.radau, thank you.

This case seems to duplicate two other issues though, which I have updated the case to include.

akbuje’s picture

akbuje CreditAttribution: akbuje as a volunteer commented
FileSize
header_and_footer_scripts-javascript-comments-fix-3050967-3.patch1.06 KB

Since I am using the change edward.radau has made, I have made his change into a patch to be reviewed for later use, if others find it useful.

akbuje’s picture

akbuje CreditAttribution: akbuje as a volunteer commented
Status: Active » Needs review
dhanlal’s picture

dhanlal CreditAttribution: dhanlal at Valuebound commented
Assigned: Unassigned » dhanlal

this patch not tested that why i update the this issue

dhanlal’s picture

dhanlal CreditAttribution: dhanlal at Valuebound commented
FileSize
header_and_footer_scripts-javascript-comments-fix-3050967-4.patch1.06 KB

need review

dhanlal’s picture

dhanlal CreditAttribution: dhanlal at Valuebound commented
dhanlal’s picture

dhanlal CreditAttribution: dhanlal at Valuebound commented
Assigned: dhanlal » Unassigned
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented

Patch in #6 by dhanlal in #6 is identical to the one submitted by akbuje in #3.

Plagiarism is just as bad as spam. Please take into account when assigning credit.

Jesmaster’s picture

Jesmaster CreditAttribution: Jesmaster commented
FileSize
header_and_footer_scripts_value_markup.patch2.21 KB

The original patch missed a few spots, here's an updated version.

Nitesh Sethia’s picture

Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer and at Syngenta commented
FileSize
header_and_footer_scripts-javascript-comments-fix-3050967-11.patch2.57 KB

Updated the patch as per the different comments and the coding standards.

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

This issue was fixed in v3.0.0.

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Assigned: Unassigned » sasiddiqui
Status: Needs review » Fixed
sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Status: Fixed » Closed (fixed)