Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

aspilicious’s picture

Status: Postponed » Active
amateescu’s picture

Assigned: Unassigned » Gábor Hojtsy
Status: Active » Needs review
Issue tags: +D8 Accelerate

I've been reading the very detailed issue summary and change records for #2212069: Non-English Drupal sites get default configuration in English, edited in English, originals not actually used if translated but I don't see any actual change to a default config file so I'm not sure what exactly would we need to provide here as an upgrade path.

My best guess after reading the patch is that we could have an update function that calls locale_system_set_config_langcodes() and locale_translate_batch_refresh() after that. @Gábor Hojtsy, is that correct or do you have any other suggestion?

Gábor Hojtsy’s picture

Well, default configuration did not change, how we handle Default configuration translations changed. If the site default language is different from English:

1. For each config file that was also a default config file (either required or optional), it should be switched from English to the site default.
2. Any config language overrides for those files should be merged into the active config itself and the override removed.
3. If English is configured on the site, any strings that were to be overwritten in 2 in active config should be written out to an English language override for the config file.

I think that is all.

amateescu’s picture

Assigned: Gábor Hojtsy » Unassigned
Status: Needs review » Needs work

That's very useful info, thanks!

amateescu’s picture

Status: Needs work » Fixed
Parent issue: » #2470185: [meta] Provide a 8.0.0-beta9 to 8.0.0-beta10 upgrade path
FileSize
3.32 KB

Committed the patch attached to 8.x-1.x.

Thanks @Gábor Hojtsy, @alexpott and @Berdir for guiding me :)

  • amateescu committed 3200638 on 8.x-1.x
    Issue #2459377: Upgrade path for #2212069 (config translations in active...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.