Problem/Motivation

There are many patches needed to support the latest versions of the H5P dependencies, and some of the patches have conflicts that need manual resolution. The pace of commits to this module is slow.

Proposed resolution

As a temporary way to help me install a working copy of the H5P module that works on PHP 8.3 and uses the latest version of dependencies I've created a fork at https://github.com/ShaunDychko/h5p on the branch 2.0.x-patched where the commit messages document which patches have been applied and have links to the d.o issues, or patches with issue numbers in their links. This might be useful for other site builders/developers wanting to get set up quickly without navigating the many open issues. To use this, add the following to your composer.json

 "repositories": [
   {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/h5p"
            ]
        },
    {
      "type": "vcs",
      "url": "https://github.com/ShaunDychko/h5p"
    },

And then run composer require drupal/h5p:dev-2.0.x-patched -W and drush h5p:copy-assets. You will need Drush 13.1+ and composer 2.1+.

Remaining tasks

Wait for some of the critical patches to get applied, namely #3497789: Support h5p/h5p-core 1.27 and h5p/h5p-editor 1.25 in H5PDrupal.php, #3309446: Remove vendor directory and composer.lock from project repository, and #3499571: Support a11y_title from h5p-core 1.27, and then delete this fork.

CommentFileSizeAuthor
#5 Screenshot 2025-02-10 at 11.31.51 AM.png86.44 KBchamilsanjeewa

Comments

shaundychko created an issue. See original summary.

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented
Issue summary: View changes
nicholass’s picture

nicholass
Primary language English
Location FL
commented
Issue summary: View changes

Adding the "exclude" for "drupal/h5p" to your code example.

nicholass’s picture

nicholass
Primary language English
Location FL
commented

I had to combine with a Drush update composer require drupal/h5p:dev-2.0.x-patched drush/drush:^13 -W

But I can confirm this updates h5p so its compatible with PHP 8.3

chamilsanjeewa’s picture

chamilsanjeewa commented
StatusFileSize
new Screenshot 2025-02-10 at 11.31.51 AM.png86.44 KB

I followed the steps and used the forked branch, but I still encountered the errors below.

Also, @shaundychko, do you plan to merge this into the module?

Only local images are allowed.

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented

@chamilsanjeewa thank you for trying out the fork. I don't have commit access to this module so I can't merge into it. The intention is to keep the fork only while waiting for the maintainers to commit the patches to the module, and then I would delete the fork. The error messages you posted are related to downloading the H5P libraries since your site is searching for files in the ./sites/default/files/h5p directory. You should confirm that your web server has permission to write to the ./sites/default/files directory.

chamilsanjeewa’s picture

chamilsanjeewa commented

Hi Shaundychko,

Thank you. Unfortunately, we can't grant write access to the server. We need to move everything using Composer and pipelines instead.

jvdkolk’s picture

jvdkolk commented

I've created an issue to discuss the future of this lovely module: https://www.drupal.org/project/h5p/issues/3522836. Maybe you can also have a look there? Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Postponed (maintainer needs more info)

Apart from #3309446: Remove vendor directory and composer.lock from project repository the rest of the issues in the issue summary are committed. Testing of the latest alpha of this module would be appreciated.