Not sure if this is a 3.x issue or if we should aim for also doing it in 2.x. But currently, all 3rd party dependencies live in the folder "vendor". That works and all, and is totally supported. But as part of fixing #3305966: Media block is allowed even if not indicated as allowed I stumbled upon this thing in gitlab CI where this creates a problem for us.

So that means we have to introduce a workaround in the pipeline. Workarounds are nice to get rid of, so this issue is for tracking that.

In theory, since it's libraries, I don't think it will be a problem to just move them. But just in case someone has some alter hooks or whatever based on paths of files, it might make sense to defer such a change to a new major version?

Comments

eiriksm created an issue. See original summary.

marcofernandes’s picture

marcofernandes commented
Status: Active » Needs work
Related issues: +#3334499: Update Gutenberg library

I made some work related to this for 3.0.x https://git.drupalcode.org/project/gutenberg/-/commit/33bb7a2dd1f4bda825...
There's still some work to do, so we'll use this issue for reference.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Do you have any thoughts regarding doing the folder move in 2.x

Probably not worth it, just to remove a couple lines in the gitlab ci file?

marcofernandes’s picture

marcofernandes commented
Status: Needs work » Fixed

@Eirik, like you pointed out, I'm just concerned of hooks changing the paths. I've already seen it "in the wild" to override some gutenberg css files.
I guess it'll be a workaround to stay for a long time :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.