Problem/Motivation

The Group module allows you to pick whether to display group admin pages using the admin or standard default theme, but Group Permissions always displays its admin pages using the default theme. This can be very jarring for users, especially when the default theme is not optimized for admin configuration forms.

Proposed resolution

Create a RouteSubscriber class to switch the theme based on Group module's use_admin_theme setting.

Issue fork group_permissions-3182893

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jstoller created an issue. See original summary.

jstoller opened merge request !2

jstoller’s picture

jstoller
he/him
CreditAttribution: jstoller as a volunteer and at California Science Center commented
Status: Active » Needs review

This is my first time using an issue fork, so not sure what the protocol is, but it's ready to go.

  • LOBsTerr committed 759d071 on 3182893-use-admin-theme 
    Issue #3182893: Add is_admin option to the route.

LOBsTerr made their first commit to this issue’s fork.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commented

@jstoller - It is not necessary to alter the route. It belongs to this module. So, I've just added the option to the route. Please check it and I will merge it

jstoller’s picture

jstoller
he/him
CreditAttribution: jstoller as a volunteer and at California Science Center commented

@LOBsTerr If you want to hardcode it in there, that's fine by me since that's how I use it, but I thought it would be a better UX if it was dynamic and responded to the setting Group provides. Presumably whichever theme someone picks for the rest of the Group interface they'll want Group Permissions to use as well.

LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commented

@jstoller altering the route we kind of do the same thing. Anyway, users can alter the route in any moment and group permissions page for me is a part of admin part

jstoller’s picture

jstoller
he/him
CreditAttribution: jstoller as a volunteer and at California Science Center commented
Status: Needs review » Reviewed & tested by the community

  • LOBsTerr committed cfca1e5 on 1.0.x authored by jstoller 
    Issue #3182893 by jstoller, LOBsTerr: Respect Group module's...
LOBsTerr’s picture

LOBsTerr CreditAttribution: LOBsTerr at European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.