Problem/Motivation

In its /config/optional directory of the module, it offers a view definition to list group members. On line #135 of this file the empty string is defined like this:

empty: '<div class="item-list"><ul><li>&lt;none&gt;</li></ul></div>'

The problem with this unnecessarily complex HTML structure is that it's untranslatable. If you search for it on localize.drupal.org, there's no such string coming up.

However, if you check Drupal core's strings, then you see that “None” is already present, so probably translated to dozens of other locales as well.

So the question is: from the UX aspect what's the point of this three-fold wrapping into HTML formatting if it does not add extra value (a bullet list which has only single one item saying “nothing” – then why is it bulleted?!) but harms internationalization instead?

Steps to reproduce

  1. Create a group
  2. Add a user without any roles
  3. Go to /group/1/members
  4. In the Roles column you see: “• <none>” – always in English, independently from the current locale of the site
  5. Expected: “Keine” / “Ninguno” / “Aucune” – depending on the current locale of the site

Proposed resolution

Replace the empty string to a single word in the YAML config.

Remaining tasks

n. a.

User interface changes

Easier for human eyes to process and grab the meaning without special < and > characters.

API changes

n. a.

Data model changes

n. a.

Issue fork group-3331923

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Balu Ertl created an issue. See original summary.

baluertl’s picture

Issue summary: View changes

kristiaanvandeneynde’s picture

Sure, why not. Will commit in a sec.

kristiaanvandeneynde’s picture

Status: Needs review » Fixed

MRs are a bit of a pain while we support 2 branches, so used a different approach. Result is the same.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.