Problem/Motivation

Currently doPreSave method is overridden to run validation, but we don't call parent doPreSave. As result preSave method never called

Proposed resolution

Add parent::doPreSave

Issue fork group-3311949

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

LOBsTerr created an issue. See original summary.

LOBsTerr opened merge request !63

lobsterr’s picture

lobsterr commented
Assigned: lobsterr » Unassigned
Status: Active » Needs review
lobsterr’s picture

lobsterr commented
Issue summary: View changes
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Should be a return statement too, thanks for catching this! Will commit later today.

lobsterr’s picture

lobsterr commented

I have added a return statement

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Already did so on my local :) Commit credit still given to you.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Pushed the wrong code, my bad. Trying to juggle a million issues atm.

ekes’s picture

ekes commented

Just going to flag here in case anyone has any ideas. Since this commit installation of a module with the configuration for a group type and its roles to throws an error. When some of the group.role.id configuration is being imported:

Error: Call to a member function getConfigDependencyName() on null in Drupal\group\Entity\GroupRole->calculateDependencies() (line 314 of /app/web/modules/contrib/group/src/Entity/GroupRole.php)

The NULL is the result of $this->getGroupType(). The configuration does include dependencies on the group.type.id config as well as the user.role.id configuration so one would hope that it's been saved already, but maybe caches? I'm going to investigate.

Also worth noting I don't think the previously imported group.role.id configuration was actually working correctly before. Why I moved to HEAD to see if this would fix it ;-)

ekes’s picture

ekes commented

Spoke too soon. Seems it's being triggered by something in our code :-(
I'll post a new issue if it's something someone else is likely to have done too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.