Problem/Motivation

\Drupal\group\GroupServiceProvider::alter triggers the following deprecation:

Not marking service definitions as public is deprecated in drupal:9.2.0 and is required in drupal:10.0.0. Call $definition->setPublic(TRUE) before calling ::setDefinition(). See https://www.drupal.org/node/3194517

setPublic() exists, so this should be safe to fix anytime.

Reporting this mostly because it's not trivial to find which service is actually causing this in a project with a lot of modules, unfortunately the deprecation messages does not mention which service is causing it.

Steps to reproduce

Proposed resolution

add $definition->setPublic(TRUE)

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 group-3240988-5.patch973 byteskristiaanvandeneynde

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

oh, this is actually in group module, moving.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Project: VariationCache » Group
Component: variationcache.module » Group (group)
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: Unassigned » siddhant.bhosale
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-3240988-5.patch973 bytes

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Assigned: siddhant.bhosale » Unassigned
Status: Needs review » Fixed

Fixed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.