Closed (fixed)
Project:
Group
Version:
8.x-1.x-dev
Component:
Group (group)
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
2 Jun 2017 at 08:22 UTC
Updated:
20 Jun 2017 at 12:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kristiaanvandeneyndeComment #3
kristiaanvandeneyndeReally excited about this one, needs tests still :)
Comment #4
legolasboThe code looks solid @kristiaanvandeneynde, but as you've pointed out yourself. it does still needs tests. I'd especially like to see some kernel or web tests that demonstrate the intent of this change.
Comment #5
kristiaanvandeneyndeThis adds unit testing for the group role synchronizer service. Need to add kernel tests now for a test-only interdiff and a complete patch.
Comment #6
kristiaanvandeneyndeJust noticed I do not need to prophesize any group role storage in the set up. Will remove that in the final patch.
Comment #7
kristiaanvandeneyndeHere we go. The test in the test-only patch looks slightly different to the one in the full patch because of the missing service.
Comment #9
legolasboMethod comment and name are contradicting each other.
testGlobalRoleCreation !== Tests whether a new global role syncs to group roles
Besides that, both mention the creation of a role, but I'm not seeing any roles getting created.
Side note:
Tests should consist of 3 specific blocks of code:
- Precondition (e.g. Optional creation of a group to test against)
- Execution (e.g. creation of the roles)
- Postcondtion (e.g. assertions that prove the roles have been created and synchronised)
Comment #10
kristiaanvandeneyndeComment #11
legolasboNitpick: This could use a blank line between the creation of the role (pre condition) and the editing of the role (execution) to separate those two concepts a little clearer.
Looks good otherwise.
Comment #13
kristiaanvandeneyndeThanks for the reviews!