When there is a node type and group type with the same machine name, both submodules try to set the permission "create TYPE".

Proposed solution:

  • Append "node" and "group" respectively
  • Notify users they may have to reset some permissions
CommentFileSizeAuthor
#7 group-2551329-7-overlapping-group-permissions.patch847 bytesPete B
#4 group-2551329-4-overlapping-group-permissions.patch3.49 KBPete B

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Fixed

Creating a release to kill off this bug asap. Adding notification to release notes.

Pete B’s picture

Pete B commented
Priority: Normal » Major
Status: Fixed » Needs review
StatusFileSize
new group-2551329-4-overlapping-group-permissions.patch3.49 KB

Hello,

This release has updated the permissions, but not things that reference those permissions.

e.g.

gnode.module line 277

        $has_access = $has_access || group_access("view $node->type", $group, $account);

Patch attached to fix this.

Thanks,
Pete

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Wow, can't believe I missed that! Thanks!

Pete B’s picture

Pete B commented
Status: Fixed » Needs review
StatusFileSize
new group-2551329-7-overlapping-group-permissions.patch847 bytes

Sorry, there were a couple more too! They didn't show up in my search of the module.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

People are going to be be annoyed with all these releases :/

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.