Missing main navigation menu at 960px wide [#2430089]

When viewing the Gratis theme on a touch device with a 960px wide viewport there is no main navigation. This was reported by a users of a LG G Pad in landscape mode and I've been able to replicate in Chrome emulating as a Google Nexus 7 (2nd gen). The issue appears to be that in styles.css there are different styles set with a max-width: 60em and min-width: 59.938em leaving a 0.62em window where nothing is displayed

Comment	File	Size	Author
#5	960pxpatch-2430089-5.patch	1.15 KB	mhawksey

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 February 2015 at 16:40

Danny Englander committed ae4c4b4 on 7.x-2.x
```
d7 - fixing [#2430089]
```

Comment #2

Danny Englander

(he/him)

CreditAttribution: Danny Englander commented 20 February 2015 at 16:41

Assigned:

Unassigned

» Danny Englander

Bad oversight on my part. I was playing around with too many changes :). I've pushed a fix to dev so if there is a chance you could test that would be great. I'd like to make a new release soon with this fix.

Comment #3

Danny Englander

(he/him)

CreditAttribution: Danny Englander commented 20 February 2015 at 16:42

Status:

Active

» Fixed

Comment #4

20 February 2015 at 16:46

Danny Englander committed 1cf8058 on 8.x-2.x
```
d8 - porting [#2430089] to drupal 8
```

Comment #5

mhawksey CreditAttribution: mhawksey commented 23 February 2015 at 21:32

File	Size
960pxpatch-2430089-5.patch	1.15 KB

Thanks for the quick fix. Just a thought that at 960px the theme is still in grid layout and as such users might expect the navigation bar. Switching to 59.938em instead of 60em would achieve this. [If it helps I'm attempting my first drupal patch]

Comment #6

Danny Englander

(he/him)

CreditAttribution: Danny Englander commented 24 February 2015 at 03:19

Hi Thanks for the patch and I really appreciate it. I think I'd like to keep the fix where it is now. Note, I actually changed some of the widths to 59.99em so there would be no gaps now. The menu media query is actually now 60em and changes over at 60.01em (961px).

Note, even if I could accept the patch, you would have had to update the Sass files and then compile the CSS. There's instructions how to do that in the readme. I do appreciate the effort though. Thanks.