I am running php7 - String is a reserved word.
Here is the error.
Fatal error: Cannot use Drupal\graphql\Utility\String as String because 'String' is a special class name in XXX/drupal/modules/graphql/src/SchemaProvider/EntitySchemaProvider.php on line 17
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | stringHelper-2715609-6.patch | 8.16 KB | martin107 |
| #5 | stringHelper-2715609-5.patch | 8.16 KB | martin107 |
Comments
Comment #2
wim leersAt least major, if not critical
Comment #3
martin107 commentedThe class is a collection of statics
String should become StringHelper ?
I will have time for this over the weekend.
Comment #4
fubhy commentedDefinitely at least Major. Also, big fail on my side for not testing with PHP7.
Comment #5
martin107 commentedAh no problem....it is easily corrected.
Instead of renaming the @file tag in the String class I just removed it as @file is deprecated.
I think I have refactored every call fingers crossed.
Comment #6
martin107 commentedSorry, I messup the file rename here is the interdiff.
diff --git a/src/Utility/SchemaHelper.php b/src/Utility/StringHelper.php
similarity index 100%
rename from src/Utility/SchemaHelper.php
rename to src/Utility/StringHelper.php
locally the test now passes.
Comment #9
fubhy commentedThanks martin!