/sites/all/libraries/grammar_parser/engine/editor.inc has a number of "continue" statements which with php 7.3.5 will take the site down.

I changed all of them to " return " so the code would run without PHP compile errors. but I do not know if that breaks the actual operation of the code

I also noticed that the ownership is sensitive also and while not related to this " reader.inc " of the wrong owner also kept the site down

Someone should look at this - as I am using the latest dev code

CommentFileSizeAuthor
#3 continue_statements-3052048-1.patch1.58 KBhitchshock

Comments

bobburns created an issue. See original summary.

bobburns’s picture

bobburns commented
Issue summary: View changes
hitchshock’s picture

hitchshock
Location Ukraine
commented
Status: Active » Needs review
StatusFileSize
new continue_statements-3052048-1.patch1.58 KB

It's look like the case where we should use continue 2;

john franklin’s picture

john franklin commented

I got "continue 2" targeting switch is equivalent to "break 2". Did you mean to use "continue 3"? when I applied this patch to the copy of Grammar Parser in the API module. Updating to use continue 3 has at least silenced the warnings, As @bobburns mentioned in the OP, I'm also not sure that's the correct thing to do.

IMHO, that block of code is confusing enough that it should be refactored into several smaller functions with clearer flow control.