New version of Views GeoJSON (alpha 3) seems stripping off "_rendered" suffix for features' properties into JSON. The result is some of the Google Store Locator module's fields (gsl_xxx) are no longer handled in the display.Please see related issue https://www.drupal.org/node/2356957

CommentFileSizeAuthor
#7 compatibility_issue_with_new_views_geojson_alpha_3-2357027-7.patch7.87 KBsylvain lavielle
#2 compatibility_issue_with_new_views_geojson_alpha_3-2357027-1.patch2.82 KBsylvain lavielle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

I've committed a patch that allows you to customize the property name.
Up to you to do it in the views if you want to use views_geojson alpha3.

This module should give the user the ability to choose which field to use.

sylvain lavielle’s picture

sylvain lavielle CreditAttribution: sylvain lavielle commented
FileSize
compatibility_issue_with_new_views_geojson_alpha_3-2357027-1.patch2.82 KB

Thanks Pol,

Here a patch to get the Google Store Locator view (google_store_locator_json_export) working with Views GeoJSON Alpha 4. Apply and revert the view if need.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

Thanks for being so quick ! Amazing :)

sylvain lavielle’s picture

sylvain lavielle CreditAttribution: sylvain lavielle commented

You're welcome ;) ,

I saw you've pushed views_geojson-7.x-1.0-alpha4 that integrates the fix this patch need to work, so thanks to you (again).

Back to this issue, this fix is just a solution for those who experiencing problem with the current version of modules (google_store_locator-7.x-1.1 and views_geojson-7.x-1.0-alpha4).

A better (and cleaner) solution for a dev branch candidate patch would be to fix the '_rendeded' suffix problem into Google Store Locator module (not by adding in into view) and create a dependency into .info file with Views GeoJSON >= 7.x-1.0-alpha3.

I saw that would be pretty easy to fix that way. If I have the time I will produce the patch quickly. If anyone have another opinion, or would produce the patch, feel free to share ;)

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

Seems perfect for me.

Thanks !

sylvain lavielle’s picture

sylvain lavielle CreditAttribution: sylvain lavielle commented
Status: Active » Needs work
sylvain lavielle’s picture

sylvain lavielle CreditAttribution: sylvain lavielle commented
FileSize
compatibility_issue_with_new_views_geojson_alpha_3-2357027-7.patch7.87 KB

here's a more reliable patch as a dev branch mergeable candidate. it skips off '_rendered' suffix, skips-off Views GeoJSON's view fields label (because labels are now used to rename JSON properties in Views Geojson 7.x-1.0-alpha4), and set a version number dependency for Views GeoJSON.

sylvain lavielle’s picture

sylvain lavielle CreditAttribution: sylvain lavielle commented
Status: Needs work » Needs review
thorandzeus’s picture

thorandzeus CreditAttribution: thorandzeus commented

I'm still having the same issue withViews Geojson 7.x-1.0-alpha4 and Views Geojson 7.x-1.0-alpha5. Any news on it?

rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Status: Needs review » Needs work

The patch is not working with latest version of the views_geojson module (7.x-1.0-beta3) and it will need a bit of rework to apply again in dev version of the module after the patch #2528458: Latest views_geojson Breaks Location Export view ("Missing Style Plugin")

Patch in applied in #2528458: Latest views_geojson Breaks Location Export view ("Missing Style Plugin") solves also this problem. Next version of the module based on the 7.x-1.x will be released with this fix.