It would be nice to be able to use more than one of your placeholders at a time, and to also add in other text around the placeholders e.g. 'label' => '!text (!href)'. I've seen the token support ticket and that is a great option too (https://drupal.org/node/2000812), but unrelated to this request, I guess. Allowing tokens from other DOM elements is another great idea (https://drupal.org/node/1778250). Ideally, all three of these can work together.

CommentFileSizeAuthor
#7 allow_multiple_tokens-2143851-7.patch1.97 KBrymo
#5 google_analytics_et_2143851_1.diff2.05 KBdavemybes
#1 google_analytics_et_2143851.diff1.55 KBdavemybes

Comments

davemybes’s picture

davemybes commented
StatusFileSize
new google_analytics_et_2143851.diff1.55 KB
frob’s picture

frob
Primary language English
commented
Status: Active » Needs review
Related issues: +#2000812: Tokens support

I like your solution. I think I will apply it to the DOM token replace solution as well (I haven't applied it because it is too narrow a solution).

I will try and review this sometime this weekend.

davemybes’s picture

davemybes commented

Thanks for the fast reply. I've actually already added the Tokens support patch to my local dev version, so merging the two would be great :)

frob’s picture

frob
Primary language English
commented

post a patch, I will roll it into dev.

davemybes’s picture

davemybes commented
StatusFileSize
new google_analytics_et_2143851_1.diff2.05 KB

Well, I guess I missed that reply :P Here's an updated version using the latest dev release which has the Token support already in it.

Status: Needs review » Needs work

The last submitted patch, 5: google_analytics_et_2143851_1.diff, failed testing.

rymo’s picture

rymo
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new allow_multiple_tokens-2143851-7.patch1.97 KB

re-rolling for test bot