New commit overwrites fix for outbound link tracking on multidomain sites [#2808067]

Comment	File	Size	Author
#3	strictvar-2808067-3.patch	679 bytes	jamessw
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 16 pass PHP 5.4 & MySQL 5.5, D7 16 pass PHP 5.5 & MySQL 5.5, D7 16 pass PHP 5.6 & MySQL 5.5, D7 16 pass PHP 7 & MySQL 5.5, D7 16 pass
	multidomain-refix.patch	1.86 KB	jamessw

Comment #1

28 September 2016 at 15:04

jamessw created an issue. See original summary.

Log in or register to post comments

Comment #2

jamessw CreditAttribution: jamessw commented 28 September 2016 at 17:52

Note- this is basically removing strict type comparisons, which I have misgiving about. Drupal is returning a string as the setting instead of an integer. It should be an integer.

Log in or register to post comments

Comment #3

jamessw CreditAttribution: jamessw commented 28 September 2016 at 18:41

File	Size
strictvar-2808067-3.patch	679 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 16 pass PHP 5.4 & MySQL 5.5, D7 16 pass PHP 5.5 & MySQL 5.5, D7 16 pass PHP 5.6 & MySQL 5.5, D7 16 pass PHP 7 & MySQL 5.5, D7 16 pass

1 file was hidden/shown/deleted

File	Size
multidomain-refix.patch	1.86 KB

Here's a patch that will actually fix the issue- it returns the correct type for the option, allowing strict type checking to stay.

Log in or register to post comments

Comment #12

18 October 2016 at 20:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #13

ben.hamelin CreditAttribution: ben.hamelin commented 26 September 2017 at 13:20

Question on issue queue status/policy. Should this really be marked as closed if the fix isn't in the master branch yet? Anyone looking for this issue isn't going to easily find it, and using the -dev branch is fine and all but I think misleading for anyone who installs this module now.
Again, maybe I'm not properly understanding the workflow of the issue queue but this seems like an issue that needs to be pushed live now.
Thanks,