Add Google Analytics HELP

I do not think there is a rule that help pages are required. The module is such simple...

Whatever I'm fine with adding your help, but please keep the lines you are removing here for google_analytics.admin_settings_form.

1. +++ b/google_analytics.module
   @@ -40,8 +40,16 @@ function google_analytics_api() {
   +      $output = '';
   +      $output .= '<h3>' . t('About') . '</h3>';
   

   Can be a one-liner

2. +++ b/google_analytics.module
   @@ -40,8 +40,16 @@ function google_analytics_api() {
   +      $output .= '<p>' . t('Google Analytics adds a web statistics tracking system to your website. This system incorporates numerous statistical features.  For an extensive listing of these features see the  <a href=":project">Google Analytics</a> project site.  Beyond that, additional information can be found at the <a href=":doco">online documentation</a>.', [':doco' => 'https://www.drupal.org/node/37694', ':project' => 'https://www.drupal.org/project/google_analytics']) . '</p>';
   

   double spaces need to be removed

3. +++ b/google_analytics.module
   @@ -40,8 +40,16 @@ function google_analytics_api() {
   +      $output .= '<dt>' . t('Additional Features') . '</dt>';
   

   ucfirst than lowercase is the drupal rule. Exceptions are only on product names.

4. +++ b/google_analytics.module
   @@ -40,8 +40,16 @@ function google_analytics_api() {
   +      $output .= '<dd>' . t('The Google Analytics module offers a bit more than basic tracking.  <em>Page Tracking</em> for instance allows you to provide a list of pages to track, or a list of pages not to track. Role and Link tracking features are also available.  For a comprehensive discussion on the setup and use of its many feature see the <a href=":doco">online documentation</a>.', [':doco' => 'https://www.drupal.org/node/37694']) . '</dd>';
   

   What should the abrivation "doco" mean?

Have tested the patch and this works with the D8 version of Google Analytics. Changing the status of it to RTBC so that this can be merged with the next set of commits of Drupal 8.

Thanks,
Nitesh Sethia

+++ b/google_analytics.module
@@ -40,8 +40,15 @@ function google_analytics_api() {
-    case 'google_analytics.admin_settings_form':
-      return t('<a href=":ga_url">Google Analytics</a> is a free (registration required) website traffic and marketing effectiveness service.', [':ga_url' => 'http://www.google.com/analytics/']);

incorrect change

1. +++ b/google_analytics.module
   @@ -40,8 +40,15 @@ function google_analytics_api() {
   +      $output .= '<p>' . t('Google Analytics adds a web statistics tracking system to your website. This system incorporates numerous statistical features. For an extensive listing of these features see the <a href=":project">Google Analytics</a> project site. Beyond that, additional information can be found at the <a href=":doco">online documentation</a>.', [':doco' => 'https://www.drupal.org/node/37694', ':project' => 'https://www.drupal.org/project/google_analytics']) . '</p>';
   

   still unclear what "doco" means.

2. +++ b/google_analytics.module
   @@ -40,8 +40,15 @@ function google_analytics_api() {
   +      $output .= '<dt>' . t('Additional features') . '</dt>'; ¶
   

   trailing space

How you added a leading/trailing tab... :-)

Have you opened a bug case for the issue already we can subscribe, too?

#2735999: hook_help() not fired inside test