Track svg links [#2537656]

Clicking on an svg link:

<a xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="/foo/bar/test">
  <polygon points="...."></polygon>
</a>

gives me:

Uncaught TypeError: this.href.match is not a function

on:

else if (Drupal.settings.googleanalytics.trackOutbound && this.href.match(/^\w+:\/\//i)) {

that's because the this.href is of type SVGAnimatedString instead of a link

Comments

Comment #1

hass CreditAttribution: hass commented 29 July 2015 at 20:39

Title:	tracking on svg link fails	» Track svg links
Version:	7.x-2.1	» 8.x-2.x-dev
Category:	Bug report	» Feature request

Comment #2

ioannis.cherouvim CreditAttribution: ioannis.cherouvim commented 30 July 2015 at 14:46

Version:

8.x-2.x-dev

» 7.x-2.x-dev

Comment #3

ioannis.cherouvim CreditAttribution: ioannis.cherouvim commented 30 July 2015 at 14:47

To solve this you can go to line 13 and add:

var href = this.getAttribute('href')||this.getAttribute('xlink:href');

and replace all occurences of this.href with href.

Comment #4

hass CreditAttribution: hass commented 30 July 2015 at 17:11

Version:

7.x-2.x-dev

» 8.x-2.x-dev

What happens if both do not exist?

Comment #5

ioannis.cherouvim CreditAttribution: ioannis.cherouvim commented 31 July 2015 at 07:11

The value of href will be null. My proposed change doesn't affect anything in this regard. It just allows the code to work with both html a and svg a elements.

If there are more clickable html/svg stuff with target hrefs (I don't know any other than html a and svg a) then we could add it.

Comment #6

hass CreditAttribution: hass commented 29 September 2017 at 16:07

Status:

Active

» Closed (won't fix)

https://developer.mozilla.org/de/docs/Web/SVG/Attribute/xlink:href

Deprecated since SVG 2
This feature has been removed from the Web standards. Though some browsers may still support it, it is in the process of being dropped. Avoid using it and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.

And: