Currently the extensions list doesn't include the new extensions for MS office documents (.docx, .xlsx, .pptx) which have been the defaults since 2007.

Additionally, not sure if they should be included but a number of extra extensions were added in Office 2007 for thing such as 'macro-enabled document'. The details are here.

CommentFileSizeAuthor
#22 Issue-2323215-Support-modern-MS-office-documents-doc-D64.patch3.07 KBhass
#21 Issue-2323215-Support-modern-MS-office-documents-doc-D64.patch3.03 KBhass
#20 Issue-2323215-Support-modern-MS-office-documents-doc.patch3 KBhass
#18 Issue-2323215-Support-modern-MS-office-documents-doc.patch2.25 KBhass
#6 googleanalytics-track-ms-open-xml-downloads-2323215-6.patch2.04 KBpq
#2 googleanalytics-track-ms-open-xml-downloads-2323215-2.patch843 bytespq
#1 googleanalytics-track-ms-open-xml-downloads-2323215-1.patch0 bytespq

Comments

pq’s picture

pq commented
StatusFileSize
new googleanalytics-track-ms-open-xml-downloads-2323215-1.patch0 bytes
pq’s picture

pq commented
StatusFileSize
new googleanalytics-track-ms-open-xml-downloads-2323215-2.patch843 bytes

Oops... sorry, this time with a non-blank patch

pq’s picture

pq commented
Status: Active » Needs review
hass’s picture

hass commented
Status: Needs review » Needs work

Thanks for sharing a patch. We should also add an update hook for this and upgrade all users using the default extension list and warn the users not using the default list about the changes. Let's also add the other extensions with macros/binary while we are already changing it.

hass’s picture

hass commented

Will you fix the outstanding bugs or should we close the case?

pq’s picture

pq commented
StatusFileSize
new googleanalytics-track-ms-open-xml-downloads-2323215-6.patch2.04 KB

Sorry, took a while to get back to this. I've added the extra extensions and the update hook.

hass’s picture

hass commented
Status: Needs work » Needs review

Thanks

Status: Needs review » Needs work

The last submitted patch, 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch, failed testing.

Status: Needs work » Needs review

PQ queued 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch, failed testing.

pq’s picture

pq commented

Not sure what's happening with the php filter tests... This patch really shouldn't affect them I'd have thought.

Status: Needs work » Needs review

hass queued 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch, failed testing.

Status: Needs work » Needs review

hass queued 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch, failed testing.

Status: Needs work » Needs review

hass queued 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: googleanalytics-track-ms-open-xml-downloads-2323215-6.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new Issue-2323215-Support-modern-MS-office-documents-doc.patch2.25 KB

There is at least one bug in the JS regex with dot[xm]?.

Status: Needs review » Needs work

The last submitted patch, 18: Issue-2323215-Support-modern-MS-office-documents-doc.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new Issue-2323215-Support-modern-MS-office-documents-doc.patch3 KB

Field is only 255, but string is 281. Increased to 500.

hass’s picture

hass commented
Version: 7.x-2.x-dev » 6.x-4.x-dev
StatusFileSize
new Issue-2323215-Support-modern-MS-office-documents-doc-D64.patch3.03 KB
hass’s picture

hass commented
StatusFileSize
new Issue-2323215-Support-modern-MS-office-documents-doc-D64.patch3.07 KB

Fixed update hook bugs

  • hass committed dd99000 on 6.x-4.x 
    Issue #2323215: Support modern MS office documents (.docx, .xlsx, .pptx)

  • hass committed a1047df on 
    Issue #2323215: Support modern MS office documents (.docx, .xlsx, .pptx)

  • hass committed ce718d0 on 8.x-2.x 
    Issue #2323215: Support modern MS office documents (.docx, .xlsx, .pptx)
hass’s picture

hass commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.