I am creating this task so work can get started on a Drupal 8 branch. We should probably tackle this issue: Rename the module so that it matches the project name to avoid confusion at that time.

CommentFileSizeAuthor
#2 CreateDrupal8Branch-1903586-2.patch107.54 KBfrob
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented
Status: Active » Postponed

First we need to know if this new api will be ready if d8 becomes ready. If D8 hits beta we should start.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented
Status: Postponed » Needs review
FileSize
CreateDrupal8Branch-1903586-2.patch107.54 KB

Personally I think we should start now.

If you create the branch then work can be done to it. I am not saying that there should be a release. This is module that many sites depend on. My module depends on this module. I want to start getting it ready for D8 so why not start now. Code Freeze is right around the corner.

I set to needs review for auto test. This patch isn't 100% all I did was a find/replace and add 8.x to the .info file.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Postponed

We are not changing the modules folder. 2.x is ONLY open to a closed beta group. We have no idea if this will be public this year or not and there are many features not yet implemented by Google, too.

Don't post any patches you have not 500% tested, please.

hass’s picture

hass CreditAttribution: hass commented

http://blog.bauermann.eng.br/2008/01/03/take-care-when-renaming-files-in...

If you rename and modify a file in the same commit, you will loose its history:

http://sourceware.org/ml/frysk/2008-q1/msg00004.html

You have to do a commit just with the rename operation (identical file contents), and then modify it. Sheesh, good to know about that!

I recall I had a similar problem with Subversion once… I think it was refusing my commit or something. I had to go back and do just the rename, commit and then modify the file.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented

RE: #3

That doesn't make any sense.

Why is there a 3.x branch if 2.x is a closed beta. How can 2.x be a closed beta if I can download and install it.

I disclosed that the patch wasn't stable. This project is too big for a single stable patch. If I don't post my work then anyone else who wants to contribute has to start at 0%. If my patch can get it to 20% then why should they have to start at 0? I'm not asking for a release, just a branch.

The short name of the module is google_analytics as per the url. As per the module naming convention the name of the module should follow throughout. This should be fixed as it creates confusion. The 8.x branch is the logical place to fix this.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented

RE: #4

Good to know, just doing this would take at least two patches.

hass’s picture

hass CreditAttribution: hass commented

The Google API used in 7.x-2.x is under closed beta on Google side. See project home, please. We may need to go to 8.x-2.x with this code so we are able to port 7.x-1.x to 8.x-1.x if the new API is not public at Drupal 8 release date. It's written that the new API is planed to become public mid 2013... we will see.

APIs are not stable in D8 yet. That's why I do not like chasing all this changes again and again. It's just tooo early now.

We rename the files first to keep the history, than we change code.

hass’s picture

hass CreditAttribution: hass commented

Marked #1948588: Google Analytics 8 upgrade as duplicate.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented

I see that this module is not so huge. But some people need it. So do I. I want to create a small Drupal 8 based sites. We able do it from scratch. But we need follow on the Drupal way.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented

For people who are needing a simple google analytics module for Drupal 8, check out Google Analytics Lite.

I created this module so that I could port my other module (that depends on Google Analytics) to Drupal 8.

hass’s picture

hass CreditAttribution: hass commented

@Frob: thanks for using this namespace. This causes now conflicts with GA. Please delete this unneeded project. Thx.

hass’s picture

hass CreditAttribution: hass commented

@Likin: feel free to share a complete and well tested patch.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented

@hass, this should not cause any namespace conflicts because the name of you module is supposed to be google_analytics, you currently have no Drupal 8 branch and my module will only be Drupal 8 and above. Thus you can fix your namespace in the Drupal 8 branch and remove any possibility of namespace collision.

Also, one cannot delete a project. Any further discussion or proposed solutions should be brought up in the Google Analytics Lite issue

hass’s picture

hass CreditAttribution: hass commented

Your module uses the namespace googleanalytics.module. This namespace was occupied for several years. You are breaking the upgrade path for ga intentionally. Ask 300.000 users if they find this acceptable, please!

hass’s picture

hass CreditAttribution: hass commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Postponed » Fixed
hass’s picture

hass CreditAttribution: hass commented

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.