Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Google map uses "zh-CN" while Drupal use "zh-Hans".
ditu.google.com has better China map than maps.google.com.
Comment | File | Size | Author |
---|---|---|---|
#16 | gmap_870350_16_china.patch | 2.34 KB | johnv |
#14 | gmap2_870350_14_china.patch | 3.86 KB | johnv |
#9 | gmap1x_870350_8_china.patch | 1.1 KB | johnv |
#5 | 870350.patch | 1.83 KB | shenzhuxi |
gmap.patch | 1.56 KB | shenzhuxi | |
Comments
Comment #1
shenzhuxi CreditAttribution: shenzhuxi commentedGoogle map uses "zh-CN" while Drupal use "zh-Hans".
This may be one the only one case in which Google api uses different local codes.
Comment #2
rogical CreditAttribution: rogical commentedGood patch, can we commit it?
Comment #3
attiks CreditAttribution: attiks commentedrelated issue #365615: Language detection not working correctly for most Chinese readers (and add a user interface for all browser language mappings)
Keep in mind that zh-hans can be any of the following:
zh-cn // China
zh-sg // Singapore
zh-hant can be:
zh-tw // Taiwan
zh-hk // Hong Kong
zh-mo // Macau
Comment #4
podarokcan You reroll this patch against latest dev ?
Comment #5
shenzhuxi CreditAttribution: shenzhuxi commentedadd zh-hans and zh-hant conditions.
Comment #6
podarok#5 looks good
commited / pushed to 7.x-2.x dev
thanks!!!
Comment #7
podarokComment #8
podarokneeds backport for 7.x-1.x-dev
Comment #9
johnvSee attached patch. In 2.4, some code was duplicated, so 1.x patch is smaller.
[Edit] there are also a few other differences, so better disregard this patch.
Comment #11
johnv@chinese folks,
The current patch & module use maps.google for the API.
According to below link, we should be using: maps.googleapis.com
https://developers.google.com/maps/documentation/geocoding/#GeocodingReq...
What is the best link for the chinese versions?
Should we still be using : //ditu.google.cn/maps/ ?
Comment #12
skyredwangI can't find any documentation suggesting that we should use different endpoints (http://maps.googleapis.com/) for different locales. Therefore, I would say that we use "http://maps.googleapis.com/" for all locale, which makes the #6 commit inappropriate.
Comment #13
podarok#9 has a lot of Notices in code
needs work
Comment #14
johnvThis patch removes //ditu.google.cn/maps/ , and does some reshuffleing.
Comment #16
johnvnew try - didn't refresh my git.
Comment #17
podarok#16 commited pushed to 7.x-2.x
thanks!!!