I updated Gmap module from 7.x-1.x-dev to 7.x-2.7 and after that when I tried to clear caches I have this error:

Fatal error: [] operator not supported for strings in .../gmap/gmap_markerinfo.inc on line 33

If I use this patch I resolve. What do you think about the patch?

Thanks

CommentFileSizeAuthor
#20 fatal_error-2110065-20.patch522 bytesValentine94
#17 fatal_error-2110065-16.patch563 bytestrrroy
#15 fatal_error-2110065-15.patch1.23 KBValentine94
#12 markerdirs_array_2110065_12.patch550 bytestomb-2
#9 markerdirs_array_2110065_9.patch546 bytestomb-2
#1 gmap.patch1.14 KBea2391
gmap.patch1.14 KBea2391
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ea2391’s picture

ea2391 CreditAttribution: ea2391 commented
FileSize
gmap.patch1.14 KB

This is the correct patch.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Version: 7.x-2.7 » 7.x-2.x-dev
Status: Active » Needs review

bot

Status: Needs review » Needs work

The last submitted patch, gmap.patch, failed testing.

jzavrl’s picture

jzavrl CreditAttribution: jzavrl commented

I also get this after i migrated from Drupal 7.22 to Drupal 7.23. Gmap version stayed the same - 7.x-2.7. I also migrated from multisite configuration to single site configuration if it matters.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented
Priority: Normal » Critical

I can confirm the problem which makes the form unusable!

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented

For a quickfix run:

variable_get('gmap_markerfiles', array(drupal_get_path('module', 'gmap') . '/markers'));

alternatively via drush "vset" command.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs work » Patch (to be ported)

right tag

rooby’s picture

rooby CreditAttribution: rooby commented
Issue summary: View changes
Status: Patch (to be ported) » Needs work

The problem is that there is no update hook to change the variable from a string to an array when upgrading from older versions of gmap, and there is no way to update that variable from the drupal UI so you get stuck.

We just need a hook_update_N() to do that.

tomb-2’s picture

tomb-2 CreditAttribution: tomb-2 commented
Status: Needs work » Needs review
FileSize
markerdirs_array_2110065_9.patch546 bytes

Ran into this issue when upgrading from Drupal 6 to 7 there seems to be no clear upgrade path to change $markerdirs from a string to an array. This patch adds an update that will change the variable from string to an array (if it is not already an array).

To use add the patch and run update.php

Status: Needs review » Needs work

The last submitted patch, 9: markerdirs_array_2110065_9.patch, failed testing.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented

You should create patch against latest 7.x-2.x-dev version

tomb-2’s picture

tomb-2 CreditAttribution: tomb-2 commented
FileSize
markerdirs_array_2110065_12.patch550 bytes

Right version, just a bad patch, here is the fixed version.

tomb-2’s picture

tomb-2 CreditAttribution: tomb-2 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: markerdirs_array_2110065_12.patch, failed testing.

Valentine94’s picture

Valentine94
Location Kyiv, Ukraine
CreditAttribution: Valentine94 commented
Status: Needs work » Needs review
FileSize
fatal_error-2110065-15.patch1.23 KB

Re-roll of https://www.drupal.org/node/2110065#comment-7957531

Status: Needs review » Needs work

The last submitted patch, 15: fatal_error-2110065-15.patch, failed testing.

trrroy’s picture

trrroy CreditAttribution: trrroy as a volunteer commented
FileSize
fatal_error-2110065-16.patch563 bytes

This patch seems to work against the current git HEAD.

trrroy’s picture

trrroy CreditAttribution: trrroy as a volunteer commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 17: fatal_error-2110065-16.patch, failed testing.

Valentine94’s picture

Valentine94
Location Kyiv, Ukraine
CreditAttribution: Valentine94 at Drupalway commented
Status: Needs work » Needs review
FileSize
fatal_error-2110065-20.patch522 bytes
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok at ITCare, FFW, Propeople (now part of FFW) commented
Status: Needs review » Fixed

#20 committed

  • podarok committed 8a98e22 on 7.x-2.x authored by Valentine94 
    Issue #2110065 by tomb, ea2391, Valentine94, trrroy: Fatal error: []...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.