Problem/Motivation

Using only one variable to sotre the settings of this module does not allow to export just one vocabulary's setting.

Proposed resolution

Following #1899420: Use vocabulary machine name instead of vid we could do a step further by splitting the settings into one variable by vocabulary. Doing so could allow site builders to export each setting with its own vocabulary.

Remaining tasks

  • Split settings to a different variable for each vocabulary
  • Include an upgrade path

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 gmap-taxonomy-split_settings-1903632-1.patch2.18 KBDuaelFr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Active » Needs review
FileSize
gmap-taxonomy-split_settings-1903632-1.patch2.18 KB

This patch is part of the #1day1patch initiative.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community

#1 thanks!

Looks good for me

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Reviewed & tested by the community » Fixed

thanks!
commited pushed to 7.x-2.x and 7.x-1.x branches

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated remaining tasks