Tooltip displays the NID if tooltip field is an entity translatable field [#1326176]

If one chooses a entity translatable field as field for tooltip
then tooltip appears with NID

on the other hand on the newest dev version the bubble text on similar situation displays the appropriatte translation of the field

Comment	File	Size	Author
#8	gmap_1326176_8_tooltip_field.patch	1.62 KB	johnv
#8
#7	gmap_1326176_6_tooltip_field.patch	1.34 KB	johnv
#7
#6	gmap_1326176_1_tooltip_field.patch	1.72 KB	johnv
#6
#1	gmap_tooltip_display_with_translatable_field.1326176_1.patch	1.39 KB	GiorgosK
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

GiorgosK

Chios, Greece 🇬🇷

CreditAttribution: GiorgosK commented 29 October 2011 at 22:23

Status:

Active

» Needs review

File	Size
gmap_tooltip_display_with_translatable_field.1326176_1.patch	1.39 KB

the problem with the code is field_alias always gets the NID as described by merlinofchaos in #5 #1160706: Views 3 and $row->{$view->field['field_id']->field_alias}

      $tooltip_field = $tooltip_field_obj->field_alias;

I created a patch using borrowed code from the bubble text since it behaves correctly

I have tested and it works correctly

PS
other possible solutions would involve extracting one of the following variables (+ additional code down the function call

      $tooltip_field = $tooltip_field_obj->field;
      $tooltip_field = $tooltip_field_obj->real_field;
      $tooltip_field = $tooltip_field_obj->field_info['field_name'];
      $tooltip_field = $tooltip_field_obj->table;

Comment #2

GiorgosK

Chios, Greece 🇬🇷

CreditAttribution: GiorgosK commented 29 October 2011 at 22:24

Comment #3

Pasqualle

🇭🇺 Budapest

CreditAttribution: Pasqualle commented 20 December 2011 at 12:21

I would call strip_tags() on tooltip as it can not display html tags.

// Remove all HTML and PHP tags from a tooltip. For best performance, we act only
// if a quick strpos() pre-check gave a suspicion (because strip_tags() is expensive).
  if (strpos($tooltip, '<') !== FALSE) {
    $tooltip = strip_tags($tooltip);
  }

Comment #4

Pasqualle

🇭🇺 Budapest

CreditAttribution: Pasqualle commented 20 December 2011 at 12:24

note: the "Rewrite results" views functionality (for the tooltip) does not work without this patch..

Comment #5

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 4 November 2012 at 00:10

Version:	7.x-1.x-dev	» 7.x-2.x-dev
Status:	Needs review	» Needs work

git apply --check gmap_tooltip_display_with_translatable_field.1326176_1.patch
error: patch failed: gmap_plugin_style_gmap.inc:102
error: gmap_plugin_style_gmap.inc: patch does not apply

this needs rerol against latest dev