CommentFileSizeAuthor
#12 notworkwithchinese.jpeg5.72 KBsealionking
#2 match_nonlattin_chars-2870027-2.patch534 byteskeesje
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pvasili created an issue. See original summary.

keesje’s picture

keesje CreditAttribution: keesje as a volunteer commented
Version: 7.x-4.x-dev » 8.x-1.x-dev
Assigned: Unassigned » keesje
FileSize
match_nonlattin_chars-2870027-2.patch534 bytes

Thanks, reproduced with "χαίρετε". Fixing this on D8 version (I maintain) first, hope for backport to D7.
Please review patch.

keesje’s picture

keesje CreditAttribution: keesje as a volunteer commented
Status: Active » Needs review
LaravZ’s picture

LaravZ CreditAttribution: LaravZ commented
Status: Needs review » Reviewed & tested by the community

The patch applied cleanly. I've tested the fix against the cyrillic script, it works nicely.

keesje’s picture

keesje CreditAttribution: keesje as a volunteer commented

Cool, you tested D8?

LaravZ’s picture

LaravZ CreditAttribution: LaravZ commented

Yes, I tested on a 8.2.7 branch. But it also applied cleanly to an empty 8.3.0 install.

  • keesje committed c8b6692 on 8.x-1.x 
    Issue #2870027 by keesje: Glossify does not work with non-latin letters...
keesje’s picture

keesje CreditAttribution: keesje as a volunteer commented
Status: Reviewed & tested by the community » Fixed

thanks, committed

keesje’s picture

keesje CreditAttribution: keesje as a volunteer commented
Version: 8.x-1.x-dev » 7.x-4.x-dev
Assigned: keesje » Unassigned
Status: Fixed » Active

reopening this for D7 maintainers, backport should be easy

LaravZ’s picture

LaravZ CreditAttribution: LaravZ commented

Is it not a duplicate of this issue for D7?

keesje’s picture

keesje CreditAttribution: keesje as a volunteer commented

euh, sorta, thanks ;-) thats an old closed issue for D6, updated but not re-opened for D7. I only maintain D8 version. Think its OK to leave this open and that one closed.

sealionking’s picture

sealionking CreditAttribution: sealionking commented
FileSize
notworkwithchinese.jpeg5.72 KB

how can make it work with Chinese？
while numbers and english works well
Chinese does not work
notworkwithchinese

sealionking’s picture

sealionking CreditAttribution: sealionking commented

patched still not work with Chinese

sealionking’s picture

sealionking CreditAttribution: sealionking commented

after rebuilding the cache with drush cr
it works with Chinese words
thanks for the patch

Casper09’s picture

Casper09 CreditAttribution: Casper09 commented

Thanks so much, it works for me, on Spain Language

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs as a volunteer and commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.