I have a client that needs functionality on their site similar to what glossify does but one of their requirements is to open links to terms in a new window and not in the same window. The attached patch provides a setting to do just that.

CommentFileSizeAuthor
#4 glossify-open_links_in_new_window-2364921-4.patch6.29 KBdustinleblanc
#3 glossify-open_links_in_new_window-2364921-3.patch6.29 KBdustinleblanc
#1 glossify-open_links_in_new_window-2364921-0.patch6.29 KBdustinleblanc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dustinleblanc’s picture

dustinleblanc
he/him/his
Primary language English
Location Ithaca, NY
CreditAttribution: dustinleblanc commented
FileSize
glossify-open_links_in_new_window-2364921-0.patch6.29 KB
dustinleblanc’s picture

dustinleblanc
he/him/his
Primary language English
Location Ithaca, NY
CreditAttribution: dustinleblanc commented
Status: Active » Needs review
dustinleblanc’s picture

dustinleblanc
he/him/his
Primary language English
Location Ithaca, NY
CreditAttribution: dustinleblanc commented
FileSize
glossify-open_links_in_new_window-2364921-3.patch6.29 KB

Fixes a spelling error in my patch.

dustinleblanc’s picture

dustinleblanc
he/him/his
Primary language English
Location Ithaca, NY
CreditAttribution: dustinleblanc commented
FileSize
glossify-open_links_in_new_window-2364921-4.patch6.29 KB

And yet another fix for whitespace... ^ embarassed that I didn't have vim setup to trim trailing whitespace already @_@

WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented
Status: Needs review » Postponed

Thanks for providing a patch. unfortunately this pushes us right smack into the middle of the 'never use _blank' debate. I'm on the fence about adding it, but if we did I think it should be more along the lines of how the link module does it and perhaps with a js option. I need to do a little more updated research on the topic.

thummel’s picture

thummel CreditAttribution: thummel commented

I need the link to open in a new window as well. The patch #4 fails:
Hunk #9 FAILED at 266.
Hunk #12 FAILED at 364.

Any update? Awesome module. Thank you for working on it.

Tracey

dustinleblanc’s picture

dustinleblanc
he/him/his
Primary language English
Location Ithaca, NY
CreditAttribution: dustinleblanc commented

Tracey,

Sorry for the slow response on that, it may be that the module has moved on since I initially provided that patch and it no longer applies. Depending on if the maintainer is interested in this functionality I could possibly re-roll.

WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented

Definitely. If a purist doesn't like the _blank method they can provide a patch that does. It with js lol.

dustinleblanc’s picture

dustinleblanc
he/him/his
Primary language English
Location Ithaca, NY
CreditAttribution: dustinleblanc at Singlebrook Technology commented

@WorldFallz, I can research doing it a JS way, you down with that?

WorldFallz’s picture

WorldFallz CreditAttribution: WorldFallz commented

Sure! That would be awesome.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
CreditAttribution: sanduhrs as a volunteer and commented
Version: 7.x-4.x-dev » 2.0.x-dev