Multilanguage environment

Hi,
I've just rewrite the db queries of this module with language conditions. I've created a patch, if you want to test it. It's not tested with Locale module disabled. Let me know if it works in your drupal setup.
Thanks

Sorry I didn't see this sooner-- always make sure patches have a 'needs work' or 'needs review' status. Patch looks good, but is non trivial and I don't have access to any multilingual environment to check. I'd like a couple of more testers to confirm and mark RTBC before committing.

thanks!

I've just finished to prepare a new patch for the 7.x-4.x branch. Thanks for your tests and reviews.

Here's the patch

Sorry my patch won't roll because of a diff between the 7.x.4 branch and the official beta release. I dig in to resolve this issue.

Ok, the patch works well with the 7.x-4.x-dev release.
Thanks to review it!

Looking forward to see this patch commited... Nobody's interested by the localization compliance ? Should I've to create a new issue ? Thanks

I'm really tired to patch each and every new release of this module... Is there a maintainer here ? thx

Please review, test and commit this patch. Thank you

Yes, there IS a maintainer here as demonstrated by my previous comment which, btw, still remains entirely valid.

I don't have access to a multi-language environment with which to test this patch so I asked for other
multi-language USERS of the module, whom this patch would benefit, to please test and provide feedback.

Nothing about that statement has changed.

Instead of making derogatory comments about those who volunteer to maintain modules (you've been a member for 7 years, how many do you maintain?), you might direct your energies to enticing other multi-language users to test the patch and report on results.

And please don't abuse issue status or priority

Sorry for the rude comment. I swear I will not do this again. I respect and love our community, even if i'm not a great contributor.

I put myself in search of multilingual environment users. May be we somebody can also test the patch in a one language environment ? This is a case to be processed.

no worries... and thank you, apology accepted! We all get frazzled and frustrated sometimes in the crazy world of open source, lol.

I wish I could test it myself -- I just have zero justification for wading into the waters of multilanguage. What I will try to do in the next week or so, is at least test it on a non-multilanguage site and make sure it doesn't break anything there.

So basically we'll still need another person or 2 to test multilanguage a 1) verify it doesn't break anything and 2) fixes the problem.

I'll comment when I've tested.

Hi,

I have tested the the latest patch (https://www.drupal.org/files/issues/glossify-localized-query-2191013-103...) on multilingual environment, it doesn't works for me. I have tried to collected the reasons to be following :

1. It searches for the translation and description in table taxonomy_term_data, which in my case doesn't contains the translated term, as it was stored in locale.
2. The only successful hit is when, the taxonomy term is translated and it's entry is there in table taxonomy_term_data.

I am submitting a patch, which assumes two conditions :

1. Module "i18n" is installed and "i18n_taxonomy" is enabled.
2. Multilingual Options on vocabulary (/admin/structure/taxonomy/glossify_terms/edit) to be set to "Locales"

Removed typo.

navneet0693's patch works for our needs (thanks!). we'll deploy it soon to our production env.

navneet0693 patch works after correcting the typo $term->id to $term->tid
(this is for localized terms)

Hello,

I've made a patch, regarding taxonomy, that is similar to previous ones, but different for following aspects:

• It handles all vocabulary i18n modes: No multilingual, Localize, Translate and Fixed Language.
• It makes use of i18n_taxonomy module API to get localized terms instead of getting it directly from the general query. Though I don't know if it's acceptable performance-wise.
• It makes sur i18n_taxonomy module is actually enabled before doing something

This is for taxonomy.

I don't have time to work on content part for now. If anyone is interested, feel free to adapt.

Putting issue as "Needs review".

Here's the patch.

Please check #25.