Allow multiple aliases to point to the same source.

CommentFileSizeAuthor
#5 globalredirect-allow_multiple_aliases-2612028-5-7.patch1.47 KBbleedev
#4 globalredirect-allow_multiple_aliases-2612028-4-7.patch1.41 KBbleedev
#3 globalredirect-allow_multiple_aliases-2612028-3-7.patch1.35 KBbleedev
#2 globalredirect-allow_multiple_aliases-2612028-1-7.patch1.25 KBbleedev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bleedev created an issue. See original summary.

bleedev’s picture

bleedev CreditAttribution: bleedev at Phase2 commented
FileSize
globalredirect-allow_multiple_aliases-2612028-1-7.patch1.25 KB
bleedev’s picture

bleedev CreditAttribution: bleedev at Phase2 commented
FileSize
globalredirect-allow_multiple_aliases-2612028-3-7.patch1.35 KB

Updated patch to work with multiple languages.

bleedev’s picture

bleedev CreditAttribution: bleedev at Phase2 commented
FileSize
globalredirect-allow_multiple_aliases-2612028-4-7.patch1.41 KB

Include language.inc (some cases it is not auto-loaded)

bleedev’s picture

bleedev CreditAttribution: bleedev at Phase2 commented
FileSize
globalredirect-allow_multiple_aliases-2612028-5-7.patch1.47 KB

Avoid strict warning for pass by reference.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Active » Needs review

I think you should explain some more what this all is needed and what the real use case is.

From the request you talk about multiple aliases. The code then deals with languages somehow.
Also, you should provide a test that describes the scenario.

Setting to needs review (dunno about the current test coverage of the module).

In any case, you should add the extra lookup code complexity only inside an if(), when your setting is enabled.

The last submitted patch, 2: globalredirect-allow_multiple_aliases-2612028-1-7.patch, failed testing.

The last submitted patch, 3: globalredirect-allow_multiple_aliases-2612028-3-7.patch, failed testing.

The last submitted patch, 4: globalredirect-allow_multiple_aliases-2612028-4-7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: globalredirect-allow_multiple_aliases-2612028-5-7.patch, failed testing.

bleedev’s picture

bleedev CreditAttribution: bleedev commented
Status: Needs work » Closed (won't fix)

This is no longer needed.

bleedev’s picture

bleedev CreditAttribution: bleedev commented