Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The variable for maintenance mode got changed from Drupal 6 to Drupal 7 - it used to be site_offline, now it's maintenance_mode. Global Redirect for D7 still incorrectly references site_offline. This patch simply updates the variable name.
Comment | File | Size | Author |
---|---|---|---|
#8 | globalredirect-maintenance-mode-1399024-8.patch | 469 bytes | markpavlitski |
Comments
Comment #2
Olarin CreditAttribution: Olarin commentedah pardon me, not only did i incorrectly submit that patch, but it looks like it's already fixed in the latest dev version anyway.
Comment #3
nicholasThompsonWell spotted...
This isn't fixed in dev.
Although the patch failed testing, marking this as RTBC due to its simplicity.
Comment #5
Fleshgrinder CreditAttribution: Fleshgrinder commentedI can confirm this problem, this is an important issue as you might end up with the
site_offline
variable set to1
butmaintenance_mode
set to0
after Drupal 7 update (yes, some people really go into maintenance mode when updating). Simply changing fromsite_offline
tomaintenance_mode
does the trick.Changed to major, pretty hardcore to debug this.
Comment #6
biosonic CreditAttribution: biosonic commentedI think I run into trouble when some other module set abandoned variable site_offline.
Comment #7
markpavlitski CreditAttribution: markpavlitski commented@Olarin Good catch! Marking back to RTBC as the patch still applies to latest 7.x-dev.
Comment #8
markpavlitski CreditAttribution: markpavlitski commentedThis is just Olarin's patch with header corrected so it applies cleanly and passes testing.
Comment #9
oadaeh CreditAttribution: oadaeh commentedChanging status to get the testbot to complete the test run.
Comment #10
oadaeh CreditAttribution: oadaeh commentedI found out from @berdir in IRC:
By the way, manually applying the fix corrected the problem for me, so back to RTBC.
Comment #11
RavindraSingh CreditAttribution: RavindraSingh commentedPatch 8 works perfectly
https://www.drupal.org/files/issues/globalredirect-maintenance-mode-1399...
Comment #12
pingwin4egYep. Without the patch in #8 the maintenance mode completely loses its beauty. Please commit!
I'm raising the priority because the issue is very old and the bug itself is simple enough to be commited ASAP w/o tests.
P.S.: @RavindraSingh this bug is not specific to 1.5 release, but to all 1.x branch.
Comment #13
Jody LynnWithout this patch my maintenance mode managed to get itself into a circular redirect and end up with a white screen.
Comment #14
beautifulmind#8 works perfectly.
Thanks @markpavlitski
Regards.
Comment #15
apmsooner CreditAttribution: apmsooner commented#8 works great for me also.
Comment #16
sushantpaste#8 Works fine for me. Thank you guys!
Comment #17
BarisW CreditAttribution: BarisW at LimoenGroen commentedThanks for the patch. Looks good to me!
Comment #19
BarisW CreditAttribution: BarisW at LimoenGroen commentedCommitted to 7.x-dev