Make version detection code an API function [#2554075]

I'm making a dev module which helps refining dependencies for version-missed modules on which other modules depend.

This is definitely done by Git Deploy module, but as it doesn't distinguish between installed/not installed modules, we get performance issues. I personally consider this approach as firing a cannon at sparrows when you only need to fetch versions for just few modules to resolve dependency-sensitive operations (update/install).

IMHO, Git Deploy module could behave more subtle, allowing to configure e.g. whether to fetch all modules or just installed modules or just few specific. But this is arguable, so I just propose to move version detection code outside git_deploy_system_info_alter() hook and make it an API function for other modules could use it. This won't harm anything.

I'm gonna make a patch.

Comment	File	Size	Author
#3	be4c4083170f13275ba741f3dd8a069a.png	15.85 KB	OnkelTem
#3	api-3.patch	8.07 KB	OnkelTem
#2	api.patch	6.4 KB	OnkelTem

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

19 August 2015 at 18:08

OnkelTem created an issue. See original summary.

Comment #2

OnkelTem CreditAttribution: OnkelTem as a volunteer commented 19 August 2015 at 22:46

File	Size
api.patch	6.4 KB

And the patch thus far:

A new function which detects versions is called git_deploy_detect_version($file). It takes only one parameter - the file object itself.
I leaved the code which skips system modules and themes in git_deploy_system_info_alter()

Not setting "Needs review" as it actually needs work: while the patch allows for calling version detection stuff from other modules, the master weapon yet not disabled and Git Deploy still makes you suffer.

Now how to resolve the issue to leave API function available and yet not fire Git Deploy master weapon?

Ideas:

Create a module configuration page with a checkbox for disengaging the master weapon.
Split the module into two: one for api, and another — for default behavior.
Thoughts?

Comment #3

OnkelTem CreditAttribution: OnkelTem as a volunteer commented 19 August 2015 at 22:31

File	Size
api-3.patch	8.07 KB
be4c4083170f13275ba741f3dd8a069a.png	15.85 KB

Implementing Idea 1 from #2 — elegantly disabling master weapon via admin/configure/system/git-deploy form while having not-configured module to behave in the old-fashioned read'em'all ways.

asd

Basically now you are not required to Disable the module to stop suffering from its slowness, you can just turn this checkbox off.

Comment #4

OnkelTem CreditAttribution: OnkelTem as a volunteer commented 19 August 2015 at 22:35

Status:

Active

» Needs review

And here comes the first (and probably the last) module exploiting newly-born API.
Meet Git deploy dependents: https://www.drupal.org/sandbox/onkeltem/2554201
Thanks @merlinofchaos for the help with naming this tiny module.

Pushing the patch to Review.