Problem/Motivation

We have an editor role with less permissions than admin users, but still with access to the admin interface and toolbar. We noticed the configured logo isn't shown for those users.

Steps to reproduce

Visit the administration interface with a user that doesn't have the admin role.

Proposed resolution

Stop hardcoding menu__toolbar__admin as theme hook throughout the code. In our case, this is menu__toolbar__editor. This issue applies the same fixes as #3458960: Toolbar logo is not visible for non-admin users.

CommentFileSizeAuthor
#5 gin_toolbar-3458962-5.png74.83 KBmaninders
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

DieterHolvoet created an issue. See original summary.

dieterholvoet’s picture

Status: Active » Needs review
jurgenhaas’s picture

Assigned: Unassigned » jurgenhaas
Issue tags: +Barcelona2024
maninders’s picture

Assigned: jurgenhaas » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new74.83 KB

After enable the module Git Toolbar(https://www.drupal.org/project/gin_toolbar), The gin toolbar will show on the frontend of the page, And after that we can see that menu on frontend view page. As an content editor role we can see that menu on frontend for content editor. Logo is coming with the menus. Adding screenshot of that.
Gin Toolbar

  • jurgenhaas committed ec224630 on 2.0.x
    Issue #3458962: Toolbar logo is not visible for non-admin users
    
    
    (...

  • jurgenhaas committed 268564b4 on 3.0.x
    Issue #3458962: Toolbar logo is not visible for non-admin users
    
jurgenhaas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.