Problem/Motivation

You can't choose to show / hide the discard and revert buttons as the config form is broken.

Steps to reproduce

- Go to settings: /admin/config/gin_lb/settings
- Toggle setting for 'Hide "Discard changes" and "Revert to defaults" buttons'
- Save form

The setting wont save and the setting also doesn't change anything with regards to the buttons.

Proposed resolution

Fix the typos in the form and save the setting.

Remaining tasks

The form element key is missing an 's' and needs to look like this

$form['hide_discard_revert_buttons'] ...
...      
 '#default_value' => $config->get('hide_discard_revert_buttons'),

And it needs this in the submit:

      ->set('hide_discard_revert_buttons', $form_state->getValue('hide_discard_revert_buttons'))

Issue fork gin_lb-3361183

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

very_random_man created an issue. See original summary.

very_random_man opened merge request !49

very_random_man’s picture

very_random_man CreditAttribution: very_random_man as a volunteer commented
Version: 1.0.0-rc3 » 1.0.x-dev
Status: Active » Needs review

Christian.wiedemann made their first commit to this issue’s fork.

Christian.wiedemann’s picture

Christian.wiedemann CreditAttribution: Christian.wiedemann commented
Status: Needs review » Fixed

Thanks!

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented

Tested ok on the last dev version. Thanks!

ChrisSnyder’s picture

ChrisSnyder
he/him
CreditAttribution: ChrisSnyder as a volunteer and at Phase2 commented

The MR on #3370248: hide_revert_button and hide_discard_button config options not working and don't have a UI. should actually fix this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.