Problem/Motivation
Noticed that when you create a new media item it uses the node-edit-form template with the right sidebar. But when you edit the same media item it doesn't
Steps to reproduce
1. Create a media item
2. Verify using right sidebar region
3. Edit media item
4. Right sidebar is not present
Proposed resolution
Consistently using right sidebar.
Remaining tasks
Implement
Review
User interface changes
TODO
API changes
N/A
Data model changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | edit-media.png | 60.71 KB | smustgrave |
| #5 | new-media.png | 57.1 KB | smustgrave |
Issue fork gin-3496235
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
saschaeggiWe're not using the sidebar only for the media entity creation, so this must be some custom config or patch.To clarify this: Media is using the sidebar but I can't reproduce that the sidebar would be missing.
Comment #3
smustgrave commentedThen can we :)
Comment #4
saschaeggiI still can't reproduce this, we'd need more steps or a video how to reproduce this
Comment #5
smustgrave commentedCurrently this is what we see when creating new media
But when we edit
Comment #6
jurgenhaasIt looks like there is a custom module in play. Out of core, there is no "View" tab for media, there is only "Edit" and that's the canonical route for media. If there is a module altering the routes so that there is one for viewing and one for editing, then the route name will be different and Gin can not recognize that route as a content entity form any longer.
Is that possible and if so, which module are you using for that?
Comment #7
smustgrave commentedJust the core media library setting.
Comment #8
jurgenhaasI'm not sure that's the case. I've tested in a fresh Drupal 11.1 installation and there is no view-tab on media entities.
Comment #9
jurgenhaasIs this something from the devel module? I see that this is enabled as well.
Comment #10
jurgenhaasFound it, there is a setting in
/admin/config/media/media-settingswhich allows enabling canonical pages for media. And that indeed changes the routing name for media entities.That's easy to fix, but I find that behaviour from core really strange.
Comment #12
jurgenhaasComment #13
smustgrave commentedThanks!
Comment #15
saschaeggiThanks both 👏