Theme logo in repo [#3278200]

Problem/Motivation

Related to issues discussed in "Project Browser" (https://www.drupal.org/project/project_browser/issues/3277464 and https://www.drupal.org/project/project_browser/issues/3277494) and creating this as a proof of concept issue/MR to show.

Feel free to accept it, change it or drop it.

Steps to reproduce

Using gitlab auto magic avatar URL, this project does not have one, so adding this file will set this file as the project's logo.
* https://git.drupalcode.org/project/gin/-/avatar 404s now.

Proposed resolution

Merge the MR with the logo to the main branch and https://git.drupalcode.org/project/gin/-/avatar should serve it.

Remaining tasks

Provide MR with logo file.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork gin-3278200

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3278200-theme-logo-in changes, plain diff MR !136
Check out this branch
8.x-3.x compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

2 May 2022 at 09:43

fjgarlin created an issue. See original summary.

Comment #2

2 May 2022 at 09:44

fjgarlin opened merge request !136

Comment #3

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented 2 May 2022 at 09:48

Status:

Active

» Needs review

Logo added. Just transformed the "gin.svg" to PNG and renamed it to "logo.png" and added it to the root of the repo.
The MR is ready to review.

Comment #4

saschaeggi

he/him

CreditAttribution: saschaeggi as a volunteer commented 2 May 2022 at 10:09

@fjgarlin is 620x620 the intented size we want to go for?

Comment #5

fjgarlin CreditAttribution: fjgarlin as a volunteer and at Drupal Association commented 2 May 2022 at 10:20

No idea on this to be honest. I just chose a big enough size so we wouldn't need to upsize at some point.

There is some comments on sizes here: https://www.drupal.org/project/project_browser/issues/3277464#comment-14... and also this other issue (https://www.drupal.org/project/project_browser/issues/3277494) is meant to set guidelines, but as everything is WIP (or not even that) is hard to settle for a particular size.

I haven't found guidelines from gitlab side other than the possibility of scaling avatars: https://docs.gitlab.com/ee/development/image_scaling.html (which seems to be WIP https://docs.gitlab.com/ee/architecture/blueprints/image_resizing/)

So it's hard to set on something other than "big enough so you (the maintainer) is happy with the resolution, but also as small as possible so the image is served fast".