Submit button in edit form is not working for forms that have an input with the name "id". This is because form.id is overridden by the element, so the logic in gin_editform.js breaks. I will provide a patch shortly.

CommentFileSizeAuthor
#2 3231922-2.patch1.59 KBs.messaris

Comments

s.messaris created an issue. See original summary.

s.messaris’s picture

s.messaris commented
Title: Edit form not working for forms that have an input with the name "id". » Submit button in edit form not working for forms that have an input with the name "id".
Issue summary: View changes
StatusFileSize
new 3231922-2.patch1.59 KB

Here is the patch, using getAttribute('id') to avoid the problem.

s.messaris’s picture

s.messaris commented
Assigned: s.messaris » Unassigned
Status: Active » Needs review
s.messaris’s picture

s.messaris commented

The implementation that is based on the form id will probably need to be changed, it also doesn't work if the whole form is replaced by ajax, as for example happens in commerce add payment form.

  • saschaeggi committed 5472776 on 8.x-3.x authored by s.messaris 
    Issue #3231922 by s.messaris: Submit button in edit form not working for...
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs review » Fixed

This is a very good improvement, thanks. We'll refactor the form actions anyway in a next step.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andres.torres’s picture

andres.torres commented

Hi All, still not sure if this issue is related to https://www.drupal.org/project/field_group/issues/2969051 but in order to make sure it gets fixed im reporting it also here. Any help is very appreciated.

andres.torres’s picture

andres.torres commented
Priority: Normal » Critical
Related issues: +#3324089: uasort(): Returning bool from comparison function is deprecated

The issue is not fixed! Using Claro-Gin under PHP 8X is triggering these errors, lets please work together to fix them on Drupal 9.5+, Since when turning back to Seven there is no issue apparently..

andres.torres’s picture

andres.torres commented
Related issues: +#2969051: Fix HTML5 validation prevents submission in tabs