Problem/Motivation

The Gutenberg module already supports Claro, so only a few tweaks have to be made.

Issue fork gin-3185910

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !7

DieterHolvoet’s picture

DieterHolvoet CreditAttribution: DieterHolvoet at Wieni commented

I (temporarily) disabled the svg path selector because it's overriding the fill of every svg on the page, it should probably be narrowed down but I don't know which elements it's targeting in the first place.

The rest of my changes are pretty straightforward. There might be more changes necessary, I haven't done an in-depth testing.

paul121’s picture

paul121 CreditAttribution: paul121 commented

We're having a similar issue with the svg path selector in the farmOS distribution: #3187591: Map control buttons that specify no fill color are overridden by CSS

perandre’s picture

perandre CreditAttribution: perandre at Frontkom commented

Good thinking adding Gutenberg support. Clap clap!

cpsarros’s picture

cpsarros CreditAttribution: cpsarros as a volunteer commented

Similar issue with Charts module

doxigo’s picture

doxigo CreditAttribution: doxigo as a volunteer commented

@Dieter I can probably jump in on the MR and see if I can add some more fixes hopefully this week

doxigo’s picture

doxigo CreditAttribution: doxigo as a volunteer commented

So I looked into gin and Gutenberg core a bit, so there are couple of issues here to note:

and more major issues that rely on Gutenberg itself

So I propose a third-party integration module rather than a gin MR which probably not gonna get merged since it’s Gutenberg’s job to fix itself rather than Gin at some point (we need to determine if the current node has the Gutenberg enabled or not)

I will see if I can start on an integration module like `gin_gutenberg` or sth like that which makes it easier to maintain and experiment in regards with both Gutenberg and Gin and at some point, if applicable we can merge it in

doxigo’s picture

doxigo CreditAttribution: doxigo as a volunteer commented

Okay I managed to get a contrib module for now going at: https://www.drupal.org/project/gin_gutenberg

Since we needed this integration sooner than later, I'll have to chunk it up to different MRs for Gin and Gutenberg

There are known issues with a module approach due to the fact that theme overrides has precedence over a module, so... I had to fix the status field ("Publish") with CSS which is not optimal at all

It would be nice if you guys could check it until I put up the MRs

doxigo opened merge request !20

doxigo’s picture

doxigo CreditAttribution: doxigo as a volunteer commented
Status: Active » Needs review

Following up on https://www.drupal.org/project/gin/issues/3202172 open a style only merge request

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented
Title: Add support for Gutenberg module » [Gutenberg] Add support for Gutenberg module
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented
Status: Needs review » Postponed (maintainer needs more info)

Is this still relevant with the existence of gin_gutenberg? Does this need a re-roll or should we close this?

doxigo’s picture

doxigo CreditAttribution: doxigo as a volunteer commented

It is now fixed without gin_gutenberg, I suppose at some point we can deprecate gin_gutenberg

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Thanks for getting back this quickly @doxigo! I'll close this as outdated then :)