Problem/Motivation

The latest release of gin is incompatible with Drupal 8.8.10.

Steps to reproduce

  • Install Drupal 8.8.10 and gin
  • Enable gin

Error:

Drupal\Core\Asset\Exception\InvalidLibrariesExtendSpecificationException: The specified library "claro/progress" does not exist. in Drupal\Core\Asset\LibraryDiscoveryCollector->applyLibrariesExtend() (line 149 of core/lib/Drupal/Core/Asset/LibraryDiscoveryCollector.php).

Proposed resolution

Revert to using classy/progress instead.

Remaining tasks

Create patch.

User interface changes

none.

API changes

none.

Data model changes

none.

CommentFileSizeAuthor
#6 Screen Shot 2020-11-13 at 4.14.53 PM.png121.09 KBacrollet
#5 3182192-5.patch338 bytessaschaeggi
#3 gin-use_classy_progress-3182192-3.patch339 bytesacrollet

Issue fork gin-3182192

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 8.x-3.x Comparecompare
  • 3182192-8.8.x-compatibility Comparecompare
About issue forks

Comments

acrollet created an issue. See original summary.

acrollet’s picture

acrollet commented

I don't know if the claro-specific implementation of progress is necessary for later versions of gin - mainly creating this issue as a placeholder for discussion and a patch.

acrollet’s picture

acrollet commented
StatusFileSize
new gin-use_classy_progress-3182192-3.patch339 bytes
saschaeggi’s picture

saschaeggi
he/him
commented

Moving back to the classy loader is not an option ;-)
But I think we can integrate the Claro loader library directly into Gin to fix this issue.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Needs review
StatusFileSize
new 3182192-5.patch338 bytes

Hey @acrollet
I did test this with 8.9 & 9.0.x again and it seems we don't need this after all.
Can you try if this patch works for you on 8.8 as well?
Cheers

acrollet’s picture

acrollet commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2020-11-13 at 4.14.53 PM.png121.09 KB

Thanks so much for the quick response and solution! Validated that the patch in #5 is working with 8.8.10:

  • saschaeggi committed 21f71a7 on 8.x-3.x 
    Issue #3182192 by acrollet, saschaeggi: 8.8.x compatibility
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

@acrollet thanks for reporting & testing!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.