Closed (fixed)
Project:
Gesso
Version:
8.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Mar 2017 at 22:11 UTC
Updated:
6 Apr 2017 at 19:59 UTC
Jump to comment: Most recent
I'm not getting any contextual links in D8. Logged in as user1, and they're working in other themes.
Comments
Comment #2
hanpersand commentedUpdating to say I can see that the theme is outputting an empty div where the contextual link trigger is supposed to be. It has no class, but it has an data-contextual-id attribute. It doesn't contain a trigger element for contextual links (like Bartik does, for example).
Comment #3
hanpersand commentedI was able to get the contextual links markup to show up by altering the Gesso block template files. I just added some text to debug, see if the templates were being used. They are, and the contextual link HTML menu appeared in the markup after I did this. I reproduced this twice on multiple copies of Gesso.
So now the contextual links are there, but I think some CSS are keeping them from showing up when focus is on the contextual region. I'm attempting to troubleshoot that and will report back if I'm able to fix it.
Comment #4
hanpersand commentedFixed! It's the focusable class included in Gesso.
The Contextual Links module loads the contextual links with a class of focusable and visually-hidden. When you mouse over the contextual region, it removes the visually-hidden class. But the Gesso focusable utility class uses the focusable mixin, which pulls in the visually-hidden mixin by default, thereby keeping the contextual links hidden even when the JS removes the visually-hidden class.
I have commented out the Gesso focusable utility class, but maybe I will rename it in my own copy so it can still be used without this conflict.
Comment #5
clafferty commentedComment #6
hanpersand commentedI renamed the focusable class in my copy of Gesso to focusable-custom. The only thing it seemed to affect in the starter theme itself was the skiplinks. I changed the class on skiplinks in html.html.twig to match my newly named focusable-custom, all good!
Comment #7
qjones3 commentedThanks hanpersand! I'm getting ready to turn on Contextual Links. You saved me many hours of tedious troubleshooting. I really appreciate your effort!
Comment #8
dcmouyard commented@hanpersand Thanks!
I fixed this issue on GitHub here: https://github.com/forumone/gesso/pull/73
For those following along, I simply separated out the visually-hidden styles from the focusable styles and added the visually-hidden class to the skiplinks.
Comment #9
dcmouyard commentedThis fix has been merged into 8.x-1.x.