Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently, the Geshi module uses 417 (!) variables to store its settings.
- 203 for its language tags (geshifilter_language_tags_php, etc)
- 203 for the enabled language (geshifilter_language_enabled_php, etc)
and some other single value settings.
Please, please, combine these settings into a few new ones.
Just geshifilter_languages_enabled and geshifilter_language_tags would, as an array.
Why? It's hell to store GESHI settings in Features now (417 checkboxes..) and it makes Drupal unnecessary slow (as all variables are loaded during bootstrap).
Comments
Comment #1
soxofaan CreditAttribution: soxofaan commentedIndeed, good point
However, I don't have time to work on this in the near future.
Comment #2
cweagans+1
I just ran into this tonight, and there's a zillion variables to export. Any chance you'll have a few minutes to look at this soon? If not, I might give it a go.
Comment #3
yukare CreditAttribution: yukare commentedIn drupal 8 they are arrays, we can do something near as i did, just replace each _ as an array. Now tests are working in drupal 7, so if someone provides a path for this that pass all the tests and have an upgrade path i will commit it, but i will not work on this now.