I get several of these warnings when adding a "distance" field.

This is due to the missing options in option_definition. I don't pretend to understand Views, but this patch seems to make the error go away.

diff --git a/handlers/geolocation_proximity_views_handler_field_distance.inc b/handlers/geolocation_proximity_views_handler_field_distance.inc
index be91ac2..ad94a02 100644
--- a/handlers/geolocation_proximity_views_handler_field_distance.inc
+++ b/handlers/geolocation_proximity_views_handler_field_distance.inc
@@ -61,6 +61,13 @@ class geolocation_proximity_views_handler_field_distance extends views_handler_f
         ),
       ),
     );
+    $options['use_filter'] = array('default' => FALSE);
+    $options['location'] = array(
+      'contains' => array(
+        'latitude' => array('default' => ''),
+        'longitude' => array('default' => '')
+      )
+    );
     return $options;
   }
CommentFileSizeAuthor
#2 geolocation_proximity-1.png12.91 KBderjochenmeyer
#2 geolocation_proximity-2.png26.59 KBderjochenmeyer
#1 geolocation_proximity-add_default_options_to_distance_field-1658832-1.patch703 bytesderjochenmeyer

Comments

derjochenmeyer’s picture

derjochenmeyer commented
StatusFileSize
new geolocation_proximity-add_default_options_to_distance_field-1658832-1.patch703 bytes

These are the errors:

Notice: Undefined index: use_filter in geolocation_proximity_views_handler_field_distance->can_expose() (line 224 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: use_filter in geolocation_proximity_views_handler_field_distance->can_expose() (line 224 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: location in geolocation_proximity_views_handler_field_distance->exposed_form() (line 156 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: location in geolocation_proximity_views_handler_field_distance->exposed_form() (line 163 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Latitude field is required.
Longitude field is required.
Notice: Undefined index: use_filter in geolocation_proximity_views_handler_field_distance->can_expose() (line 224 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: use_filter in geolocation_proximity_views_handler_field_distance->can_expose() (line 224 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: use_filter in geolocation_proximity_views_handler_field_distance->can_expose() (line 224 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: location in geolocation_proximity_views_handler_field_distance->exposed_form() (line 156 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Notice: Undefined index: location in geolocation_proximity_views_handler_field_distance->exposed_form() (line 163 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).
Latitude field is required.
Longitude field is required.
Notice: Undefined index: use_filter in geolocation_proximity_views_handler_field_distance->can_expose() (line 224 of /sites/default/modules/geolocation_proximity/handlers/geolocation_proximity_views_handler_field_distance.inc).

Added a patch for testing.

@Peter Bex: Thanks for reporting and the patch!

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Needs work
StatusFileSize
new geolocation_proximity-2.png26.59 KB
new geolocation_proximity-1.png12.91 KB

I tested this on simplytest.me

It seems this patch needs more work. If distance FIELD and exposed distance FILTER are used together things start working only after entering default values for latitude and longitude (e.g. 0) in both filter and field. These default values are ALSO needed if the reference for calculating the distance is set to use the filter values!

geolocation_proximity-1.png

geolocation_proximity-2.png

It seems we need a patch that at least sets default values to 0.