Draggable Marker

Nice patch! But sometimes after dropping marker, zoom changes from current one. I also recommend changing setCenter method to panTo method on onDragEnd fucntion.

Excellent and really fast job joelpittet! Will this patch committed?

Hello

Really sorry for the delay
and many thanks for the patch

Implemented just the drag, not the panTo nor the setCenter options.
I don't feel moving without the user requesting it would be a good idea.
I don't this would be used for lon drags, which makes me thing, moving the map would make the pointer loose the marker focus, which would make it harder to make multiple drags, like when trying to pin it to a veri specific location.

Any ways, sorry again for the delay.

Hi, thanks for all your help

Actually i does have a point of reference.
In JS, when you pass a function as an argument, the function will carry all the variables that were visible just before the function call to within itself. The variable i which is an argument in the parent function, remains visible inside the callback.

That means that if we have:

  Drupal.geolocation.setMapMarker = function(latLng, i) {
    // remove old marker
    if (Drupal.geolocation.markers[i]) {
      Drupal.geolocation.markers[i].setMap(null);
    }
    Drupal.geolocation.markers[i] = new google.maps.Marker({
      map: Drupal.geolocation.maps[i],
      draggable: Drupal.settings.geolocation.settings.marker_draggable ? true : false,
      // I dont like this much, rather have no effect
      // Will leave it to see if someone notice and shouts at me!
      // If so, will see consider enabling it again
      // animation: google.maps.Animation.DROP,
      position: latLng
    });
    console.log(i);
    console.log(Drupal.geolocation.markers[i]);

    google.maps.event.addListener(Drupal.geolocation.markers[i], 'dragend', function(me) {
      console.log(i);
      console.log(Drupal.geolocation.markers[i]);
      Drupal.geolocation.codeLatLng(me.latLng, i, 'marker');
      Drupal.geolocation.setMapMarker(me.latLng, i);
    });

    return false; // if called from <a>-Tag
  }

The console.log form outside will print the same as the inside of the callback.

This has a drawback, if we have too many variables in scope, they will persist in memory and can end up using too much memory, but the only big var is

  Drupal.geolocation.markers

which is in memory anyways since we need it to persist, so no memory issues here.

About the me.latLng, google passes an event argument to the callback, which is the one you see in function(me). (I think I named it me, for marked/map event)
So from that side, I'm just using what the google api gives me.

ANy ways, new dev version is available.
Will release 1.1 asap.

Cheers

I'm closing this as a feature request.

Will open new for implementing .panTo(latLng) #1526280: Implement .panTo() in draggable markes

I just realized there is an even more compelling reason, even if the bug has been fixed, creating it as an independent function would give other JS the possibility to override it, which would make it more flexible.

I'll change it to what you suggest.

As for the console.log, commit didn't include them, it was just an example.

Thanks for all your input!