When installing a group of modules, like in an install profile for example, the geoip module errors out with an undefined function error, claiming that 'libraries_detect' does not exist.

It seems to be a common pattern pattern in install hooks to use module_load_include even on module files. I can't find specific documentation which says you must load the module files of dependencies, but it's mentioned briefly here:

> When you are installing a module that is dependent on another module, the other module might not be 100% functional.

There are lots of other examples of this in contrib and one in core with openid doing a module_load_include on itself.

CommentFileSizeAuthor
#2 2547397-module-load-include-geoip.patch433 bytesSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Status: Active » Needs review
FileSize
433 bytes
jibran’s picture

Status: Needs review » Reviewed & tested by the community

Look good to me.

das-peter’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the patch - sorry for the late response, just now adjusted my issue subscription for this project ;)

  • das-peter committed 44bbfbf on 7.x-2.x authored by Sam152
    Issue #2547397 by Sam152: Use module_load_include on libraries module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.