Problem/Motivation

After #3136429: Empty results are cached wrongly geocoding is broken. No matter which geocoding plugin is selected, the geocoding process will always return an empty result.

Steps to reproduce

Have some entity with geocoding set up. Clear the cache. Every time you save the entity, the target field for the geocoding will be empty and if geocoder_log_empty_results is set, 'No results for geocoding' will be logged.

Proposed resolution

Fix the missing check for $geometry === NULL in geocoder_widget_get_field_value

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Feuerwagen created an issue. See original summary.

Feuerwagen’s picture

Status: Active » Needs review
FileSize
668 bytes
Feuerwagen’s picture

Ronino’s picture

#2 fixes it for me, thanks!

thegreatone’s picture

Yes, same here, #2 fixed my problem!
Thanks

m.stenta’s picture

Status: Needs review » Reviewed & tested by the community

This also fixed it for me! Thanks @Feuerwagen!

Marking this as RTBC - would be great to have this fixed in a release soon. :-)

  • itamair committed 128ae30 on 7.x-1.x authored by Feuerwagen
    Issue #3181471 by Feuerwagen: No geocoding with empty cache
    
itamair’s picture

Status: Reviewed & tested by the community » Fixed

Committed into dev and into new 7.x-1.7 release.
Time to move to D8 guys.
I am not maintainer of the Geocoder 7.x branch and nobody is maintaining that anymore.
I am going to flag the Geocoder 7.x branch as unsupported soon ...

m.stenta’s picture

Thanks @itamair!

Time to move to D8 guys.

Already working on it. ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.