Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
After #3136429: Empty results are cached wrongly geocoding is broken. No matter which geocoding plugin is selected, the geocoding process will always return an empty result.
Steps to reproduce
Have some entity with geocoding set up. Clear the cache. Every time you save the entity, the target field for the geocoding will be empty and if geocoder_log_empty_results
is set, 'No results for geocoding' will be logged.
Proposed resolution
Fix the missing check for $geometry === NULL
in geocoder_widget_get_field_value
Comment | File | Size | Author |
---|---|---|---|
#2 | no_geocoding_with_empty_cache-3181471-1.patch | 668 bytes | Feuerwagen |
Comments
Comment #2
FeuerwagenComment #3
FeuerwagenComment #4
Ronino CreditAttribution: Ronino as a volunteer commented#2 fixes it for me, thanks!
Comment #5
thegreatone CreditAttribution: thegreatone commentedYes, same here, #2 fixed my problem!
Thanks
Comment #6
m.stentaThis also fixed it for me! Thanks @Feuerwagen!
Marking this as RTBC - would be great to have this fixed in a release soon. :-)
Comment #8
itamair CreditAttribution: itamair as a volunteer commentedCommitted into dev and into new 7.x-1.7 release.
Time to move to D8 guys.
I am not maintainer of the Geocoder 7.x branch and nobody is maintaining that anymore.
I am going to flag the Geocoder 7.x branch as unsupported soon ...
Comment #9
m.stentaThanks @itamair!
Already working on it. ;-)