Problem/Motivation

@ctrladel pointed out that the image component is not included in our main bundle.

While experimenting with SSR and Declarative Shadow DOM I noticed that only a subset of our source JS files are distributed with the package, and they also can not be imported as modules.

This may have the side effect of solving the issue in https://www.drupal.org/project/gdwc/issues/3220866 without requiring changing the file extension, which would be a breaking change.

Remaining tasks

* Add image (and any other missing components) to the main bundle.
* Add individual js files to the files array in package.json.
* Add exports for individual js files in package.json.
* Add type: module to package.json

Issue fork gdwc-3314179

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

brianperry created an issue. See original summary.

brianperry opened merge request !58

  • brianperry committed fe6888c on 1.0.x 
    Issue #3314179 by brianperry, finnsky: Add Missing Components to Package

brianperry credited finnsky.

brianperry’s picture

brianperry
he/him
commented
Assigned: brianperry » Unassigned
Status: Active » Fixed

Merged and published on NPM as 4.0.0 as this is technically a breaking change.

Credited @finnsky on the commit - his work on https://www.drupal.org/project/gdwc/issues/3220866 was a base for some of this.

brianperry credited ctrlADel.

brianperry’s picture

brianperry
he/him
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.